From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v15 1/4] ethdev: add apis to support access device info Date: Wed, 15 Jul 2015 12:27:07 +0200 Message-ID: <4907797.WMXsT5lYd9@xps13> References: <1432946276-9424-1-git-send-email-liang-min.wang@intel.com> <7196644.zbOgvuZnbg@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: "Wang, Liang-min" Return-path: Received: from mail-wi0-f169.google.com (mail-wi0-f169.google.com [209.85.212.169]) by dpdk.org (Postfix) with ESMTP id C6F37CF9 for ; Wed, 15 Jul 2015 12:28:19 +0200 (CEST) Received: by widjy10 with SMTP id jy10so124546480wid.1 for ; Wed, 15 Jul 2015 03:28:19 -0700 (PDT) In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2015-07-15 10:07, Wang, Liang-min: > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > Please precise offset from which point? > > Why offset is needed? > > > Is C always 0-base? > The offset is introduced because one of the review requesting to support partial register read, > meaning reading single register or a set of registers. > As comment in my reply, this implementation only supports total register dump, > but the data structure design allows future expansion to support this request. OK, so the comment should be something like "Offset in register table" > > What means magic? Is it always a device id? > This field is the same as defined in kernel ethtool data structure. Not an excellent argument :) Actually you didn't answer. > > > --- a/lib/librte_ether/rte_ether_version.map > > > +++ b/lib/librte_ether/rte_ether_version.map > > > @@ -114,5 +114,11 @@ DPDK_2.1 { > > > rte_eth_timesync_enable; > > > rte_eth_timesync_read_rx_timestamp; > > > rte_eth_timesync_read_tx_timestamp; > > > + rte_eth_dev_default_mac_addr_set; > > > + rte_eth_dev_reg_length; > > > + rte_eth_dev_reg_info; > > > + rte_eth_dev_eeprom_length; > > > + rte_eth_dev_get_eeprom; > > > + rte_eth_dev_set_eeprom; > > > > It is not in alphabetical order. > Is there a document on such requirement? No, only emails. Every .map are alphabetically sorted. It's easier to check symbols. > I'm asking this question because different API's are added at different time. > Does this comment apply on relative order or absolute order meaning order relative to mainline code? Relative to mainline. Conflicts are handled when applying.