From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A3D8C4338F for ; Sun, 22 Aug 2021 08:01:27 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 79C9661051 for ; Sun, 22 Aug 2021 08:01:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 79C9661051 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:57774 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mHiQ1-0004Jl-BP for qemu-devel@archiver.kernel.org; Sun, 22 Aug 2021 04:01:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:32850) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mHiOf-0003XE-UA for qemu-devel@nongnu.org; Sun, 22 Aug 2021 04:00:01 -0400 Received: from mail-pj1-x1030.google.com ([2607:f8b0:4864:20::1030]:43537) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mHiOe-0002qd-6w for qemu-devel@nongnu.org; Sun, 22 Aug 2021 04:00:01 -0400 Received: by mail-pj1-x1030.google.com with SMTP id qe12-20020a17090b4f8c00b00179321cbae7so10090026pjb.2 for ; Sun, 22 Aug 2021 00:59:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=BzLb69KE3sI/qoFBeyJQ0nZw96fiXAf1o+2CZS2ZIHY=; b=GslRPnb3H/QxF+waTz1lubnsGSyrMvE7ehziXrIPbisb+UQckeZ+YK9djkzaQFGV47 SG9vBsxUW3L/H5NH9EWyIqHiEg5YTinvV0qNFpI6H2SPWoleuQ4NsBM4HQmjLNMOI05A mCIU+vnEx+4hOi8KIK7XRWuy+9rCOY8lbY7dXexasZ99PCQGzQZ6jfutfu66b4eciwFo ap1cMo41iFDYzl/zfKWny/QQcYMC5BHCSldVuUZGqgLpYKOY+BZiP/AuYBsgOTv3sMsC wbb5KzQpA+X+9pIEGrEtH2y7iG3qf1T0HWuXKqxOroUXPXvtyEde97jy+f3f0oPYythL sLjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=BzLb69KE3sI/qoFBeyJQ0nZw96fiXAf1o+2CZS2ZIHY=; b=jV5FpXyX5lzgeIEcNmMAhe7ZLOxR/7aetUI37lnph7rzJ6D3bkxOoBsG9/031wedCb FdIwsvxO6kH5m5Fmz3+ClP2ysHtMhCaKNrwLoszGtWtBCY03U5Y1b+j5HB4dfnY6HB7w 4qzGgdvXHTl6j+czgghdFsHcuxVMCRcOxs5y6hcsi8SLGVSbkGN3Souy9iplZep30Rf+ MY6odlT+/jkRV6JPLotDrxYLX+sIKYoSFyLiZwXVyawYkU0FqBoiYUtwhXZ6/74EydTX 0sEa/creO8JJ9GaLyYCRqkEpw+tvkrtk08k6ChurlN/1Y7L4ny0FOuXL9tDzg00hws6D kzsQ== X-Gm-Message-State: AOAM531kawFza05YE1jIMw//m46Q/ccuKBMmDCelfVPgFkfj6d/hKR5J Aeg+NZCS/oKpqNi9uv6CE94tOZ8b6RwQbA== X-Google-Smtp-Source: ABdhPJwma2dOQX1H5OZf11vcPcERWKmOJOkDgiy2+IMLpXaGbEngO0gnGWhiixzOWpb24jnblhcvFw== X-Received: by 2002:a17:90b:1c92:: with SMTP id oo18mr13919779pjb.56.1629619198285; Sun, 22 Aug 2021 00:59:58 -0700 (PDT) Received: from [192.168.1.11] ([71.212.149.176]) by smtp.gmail.com with ESMTPSA id x1sm11858811pfn.64.2021.08.22.00.59.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 22 Aug 2021 00:59:58 -0700 (PDT) Subject: Re: [PATCH v3 63/66] tcg/tci: Support raising sigbus for user-only To: Peter Maydell References: <20210818191920.390759-1-richard.henderson@linaro.org> <20210818191920.390759-64-richard.henderson@linaro.org> From: Richard Henderson Message-ID: <490decb4-1cb1-b1b4-8d4b-a72de60d51b7@linaro.org> Date: Sun, 22 Aug 2021 00:59:56 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::1030; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x1030.google.com X-Spam_score_int: -35 X-Spam_score: -3.6 X-Spam_bar: --- X-Spam_report: (-3.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-1.49, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: QEMU Developers Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 8/20/21 3:14 AM, Peter Maydell wrote: >> @@ -296,7 +296,7 @@ static uint64_t tci_qemu_ld(CPUArchState *env, target_ulong taddr, >> uintptr_t ra = (uintptr_t)tb_ptr; >> >> #ifdef CONFIG_SOFTMMU >> - switch (mop) { >> + switch (mop & (MO_BSWAP | MO_SSIZE)) { >> case MO_UB: >> return helper_ret_ldub_mmu(env, taddr, oi, ra); >> case MO_SB: >> @@ -326,10 +326,14 @@ static uint64_t tci_qemu_ld(CPUArchState *env, target_ulong taddr, >> } >> #else >> void *haddr = g2h(env_cpu(env), taddr); >> + unsigned a_mask = (1u << get_alignment_bits(mop)) - 1; >> uint64_t ret; >> >> set_helper_retaddr(ra); >> - switch (mop) { >> + if (taddr & a_mask) { >> + helper_unaligned_ld(env, taddr); >> + } >> + switch (mop & (MO_BSWAP | MO_SSIZE)) { >> case MO_UB: >> ret = ldub_p(haddr); >> break; >> @@ -377,11 +381,11 @@ static uint64_t tci_qemu_ld(CPUArchState *env, target_ulong taddr, >> static void tci_qemu_st(CPUArchState *env, target_ulong taddr, uint64_t val, >> MemOpIdx oi, const void *tb_ptr) >> { >> - MemOp mop = get_memop(oi) & (MO_BSWAP | MO_SSIZE); >> + MemOp mop = get_memop(oi); >> uintptr_t ra = (uintptr_t)tb_ptr; > > Don't you need this bit in tci_qemu_st() as well ? Which bit isn't present in st as well? There's missing hunks in your reply, but afaics they're the same. r~