From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753166AbdC0MWr (ORCPT ); Mon, 27 Mar 2017 08:22:47 -0400 Received: from mail-wr0-f196.google.com ([209.85.128.196]:34506 "EHLO mail-wr0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753195AbdC0MWc (ORCPT ); Mon, 27 Mar 2017 08:22:32 -0400 Subject: Re: [PATCH v2] staging: goldfish: Fix style issues in macros To: Frans Klaver References: <159caafb-be9c-32d7-9a15-e8593e93ddca@gmail.com> Cc: Greg KH , devel@driverdev.osuosl.org, "linux-kernel@vger.kernel.org" From: aviyae Message-ID: <490f2ef9-d1d7-6d69-4b6c-7ad5ae44f209@gmail.com> Date: Mon, 27 Mar 2017 15:13:53 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I'll remove that eudyptula thing, although there are some patches that mention it (run git log --grep=eudyptula) On 27/03/17 15:05, Frans Klaver wrote: > On Mon, Mar 27, 2017 at 1:52 PM, aviyae wrote: >> From: Aviya Erenfeld >> >> staging: goldfish: Fix style issues in macros >> >> Fix coding style issues in macros: >> 1. Add parenthesis around macros argument >> 2. Avoid arguments reuse in macros >> >> (For the eudyptula challenge) > How is that relevant? > > Frans