[Buildroot] [PATCH] json-c: needs host-autoconf

[Buildroot] [PATCH] json-c: needs host-autoconf

[Baruch Siach]

The json-c configure script uses the autoheader utility. Use the
host-autoconf provided autoheader, as this tool is not always installed
on the host.

Fixes:
http://autobuild.buildroot.net/results/030/030fddceda4f5bc6379f7bfcc405e92d2e24184a/
http://autobuild.buildroot.net/results/e48/e482f174b8124ace0690a26bb7daf073fe5fcd75/
http://autobuild.buildroot.net/results/482/4829425c38c58d9844aa07108532a93d47191d23/

Cc: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
 package/json-c/json-c.mk | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/package/json-c/json-c.mk b/package/json-c/json-c.mk
index 57d8c35dd5e3..bee57577ceec 100644
--- a/package/json-c/json-c.mk
+++ b/package/json-c/json-c.mk
@@ -10,5 +10,9 @@ JSON_C_INSTALL_STAGING = YES
 JSON_C_LICENSE = MIT
 JSON_C_LICENSE_FILES = COPYING
 
+# configure requires autoheader
+JSON_C_DEPENDENCIES = host-autoconf
+HOST_JSON_C_DEPENDENCIES = host-autoconf
+
 $(eval $(autotools-package))
 $(eval $(host-autotools-package))
-- 
2.18.0

[Buildroot] [PATCH] json-c: needs host-autoconf

[Peter Korsgaard]

>>>>> "Baruch" == Baruch Siach <baruch@tkos.co.il> writes:

 > The json-c configure script uses the autoheader utility. Use the
 > host-autoconf provided autoheader, as this tool is not always installed
 > on the host.

 > Fixes:
 > http://autobuild.buildroot.net/results/030/030fddceda4f5bc6379f7bfcc405e92d2e24184a/
 > http://autobuild.buildroot.net/results/e48/e482f174b8124ace0690a26bb7daf073fe5fcd75/
 > http://autobuild.buildroot.net/results/482/4829425c38c58d9844aa07108532a93d47191d23/

 > Cc: Fabrice Fontaine <fontaine.fabrice@gmail.com>
 > Signed-off-by: Baruch Siach <baruch@tkos.co.il>

Committed, thanks.

-- 
Bye, Peter Korsgaard

[Buildroot] [PATCH] json-c: needs host-autoconf

[Thomas Petazzoni]

Hello,

On Tue, 28 Aug 2018 17:54:47 +0300, Baruch Siach wrote:
> The json-c configure script uses the autoheader utility. Use the
> host-autoconf provided autoheader, as this tool is not always installed
> on the host.
> 
> Fixes:
> http://autobuild.buildroot.net/results/030/030fddceda4f5bc6379f7bfcc405e92d2e24184a/
> http://autobuild.buildroot.net/results/e48/e482f174b8124ace0690a26bb7daf073fe5fcd75/
> http://autobuild.buildroot.net/results/482/4829425c38c58d9844aa07108532a93d47191d23/
> 
> Cc: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
>  package/json-c/json-c.mk | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/package/json-c/json-c.mk b/package/json-c/json-c.mk
> index 57d8c35dd5e3..bee57577ceec 100644
> --- a/package/json-c/json-c.mk
> +++ b/package/json-c/json-c.mk
> @@ -10,5 +10,9 @@ JSON_C_INSTALL_STAGING = YES
>  JSON_C_LICENSE = MIT
>  JSON_C_LICENSE_FILES = COPYING
>  
> +# configure requires autoheader
> +JSON_C_DEPENDENCIES = host-autoconf
> +HOST_JSON_C_DEPENDENCIES = host-autoconf

Wait, wait, why is this needed? This is a standard autotools package,
it shouldn't need autoheader at build time.

Isn't it that there is a bogus timestamp or something like that forces
some files to be re-generated ?

This problem only appears on Joseph's machine:
http://autobuild.buildroot.net/?reason=json-glib%.

It doesn't happen on my autobuilder, even though it doesn't have
autoheader installed system-wide.

So I'm skeptical about this fix.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[Buildroot] [PATCH] json-c: needs host-autoconf

[Thomas Petazzoni]

Hello,

On Tue, 28 Aug 2018 21:35:57 +0200, Thomas Petazzoni wrote:

> Wait, wait, why is this needed? This is a standard autotools package,
> it shouldn't need autoheader at build time.
> 
> Isn't it that there is a bogus timestamp or something like that forces
> some files to be re-generated ?
> 
> This problem only appears on Joseph's machine:
> http://autobuild.buildroot.net/?reason=json-glib%.
> 
> It doesn't happen on my autobuilder, even though it doesn't have
> autoheader installed system-wide.

Sorry, I messed up here: the package being fixed is json-c, not
json-glib. So the build failure does occur on several autobuilders:
http://autobuild.buildroot.net/?reason=json-c%.

However, I would still like to see an explanation of why autoheader is
needed in an autotools package. It should not be needed.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[Buildroot] [PATCH] json-c: needs host-autoconf

[Baruch Siach]

Hi Thomas,

Thomas Petazzoni writes:
> On Tue, 28 Aug 2018 21:35:57 +0200, Thomas Petazzoni wrote:
>> Wait, wait, why is this needed? This is a standard autotools package,
>> it shouldn't need autoheader at build time.
>> 
>> Isn't it that there is a bogus timestamp or something like that forces
>> some files to be re-generated ?
>> 
>> This problem only appears on Joseph's machine:
>> http://autobuild.buildroot.net/?reason=json-glib%.
>> 
>> It doesn't happen on my autobuilder, even though it doesn't have
>> autoheader installed system-wide.
>
> Sorry, I messed up here: the package being fixed is json-c, not
> json-glib. So the build failure does occur on several autobuilders:
> http://autobuild.buildroot.net/?reason=json-c%.
>
> However, I would still like to see an explanation of why autoheader is
> needed in an autotools package. It should not be needed.

You are right. Updating the config.h.in timestamp is enough to avoid
autoheader. I sent an updated patch.

Thanks for noting.

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -

[Buildroot] [PATCH] json-c: needs host-autoconf

[Thomas Petazzoni]

Hello,

On Wed, 29 Aug 2018 07:10:38 +0300, Baruch Siach wrote:

> You are right. Updating the config.h.in timestamp is enough to avoid
> autoheader. I sent an updated patch.

Thanks a lot for looking deeper into this. Perhaps this issue should be
reported upstream, because it's really a bug in upstream's tarball.

Thanks again!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com