From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6A44C433ED for ; Mon, 19 Apr 2021 09:32:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7CA0961165 for ; Mon, 19 Apr 2021 09:32:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238088AbhDSJcu (ORCPT ); Mon, 19 Apr 2021 05:32:50 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:16480 "EHLO szxga05-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232440AbhDSJcs (ORCPT ); Mon, 19 Apr 2021 05:32:48 -0400 Received: from DGGEMS410-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4FP1kD4zpFzqTsr; Mon, 19 Apr 2021 17:29:56 +0800 (CST) Received: from [10.174.187.224] (10.174.187.224) by DGGEMS410-HUB.china.huawei.com (10.3.19.210) with Microsoft SMTP Server id 14.3.498.0; Mon, 19 Apr 2021 17:32:09 +0800 Subject: Re: [PATCH v3 02/12] iommu: Add iommu_split_block interface To: Lu Baolu , , , , Robin Murphy , Will Deacon , "Joerg Roedel" , Yi Sun , "Jean-Philippe Brucker" , Jonathan Cameron , Tian Kevin References: <20210413085457.25400-1-zhukeqian1@huawei.com> <20210413085457.25400-3-zhukeqian1@huawei.com> CC: Alex Williamson , Cornelia Huck , Kirti Wankhede , , , , From: Keqian Zhu Message-ID: <491da550-dc54-42e6-ac91-13d411575fad@huawei.com> Date: Mon, 19 Apr 2021 17:32:08 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.187.224] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Baolu, On 2021/4/14 15:14, Lu Baolu wrote: > On 4/13/21 4:54 PM, Keqian Zhu wrote: >> Block(largepage) mapping is not a proper granule for dirty log tracking. >> Take an extreme example, if DMA writes one byte, under 1G mapping, the >> dirty amount reported is 1G, but under 4K mapping, the dirty amount is >> just 4K. >> >> This adds a new interface named iommu_split_block in IOMMU base layer. >> A specific IOMMU driver can invoke it during start dirty log. If so, the >> driver also need to realize the split_block iommu ops. >> >> We flush all iotlbs after the whole procedure is completed to ease the >> pressure of IOMMU, as we will hanle a huge range of mapping in general. >> >> Signed-off-by: Keqian Zhu >> Signed-off-by: Kunkun Jiang >> --- >> drivers/iommu/iommu.c | 41 +++++++++++++++++++++++++++++++++++++++++ >> include/linux/iommu.h | 11 +++++++++++ >> 2 files changed, 52 insertions(+) >> >> diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c >> index 667b2d6d2fc0..bb413a927870 100644 >> --- a/drivers/iommu/iommu.c >> +++ b/drivers/iommu/iommu.c >> @@ -2721,6 +2721,47 @@ int iommu_domain_set_attr(struct iommu_domain *domain, >> } >> EXPORT_SYMBOL_GPL(iommu_domain_set_attr); >> +int iommu_split_block(struct iommu_domain *domain, unsigned long iova, >> + size_t size) >> +{ >> + const struct iommu_ops *ops = domain->ops; >> + unsigned int min_pagesz; >> + size_t pgsize; >> + bool flush = false; >> + int ret = 0; >> + >> + if (unlikely(!ops || !ops->split_block)) >> + return -ENODEV; >> + >> + min_pagesz = 1 << __ffs(domain->pgsize_bitmap); >> + if (!IS_ALIGNED(iova | size, min_pagesz)) { >> + pr_err("unaligned: iova 0x%lx size 0x%zx min_pagesz 0x%x\n", >> + iova, size, min_pagesz); >> + return -EINVAL; >> + } >> + >> + while (size) { >> + flush = true; >> + >> + pgsize = iommu_pgsize(domain, iova, size); >> + >> + ret = ops->split_block(domain, iova, pgsize); >> + if (ret) >> + break; >> + >> + pr_debug("split handled: iova 0x%lx size 0x%zx\n", iova, pgsize); >> + >> + iova += pgsize; >> + size -= pgsize; >> + } >> + >> + if (flush) >> + iommu_flush_iotlb_all(domain); >> + >> + return ret; >> +} >> +EXPORT_SYMBOL_GPL(iommu_split_block); > > Do you really have any consumers of this interface other than the dirty > bit tracking? If not, I don't suggest to make this as a generic IOMMU > interface. > > There is an implicit requirement for such interfaces. The > iommu_map/unmap(iova, size) shouldn't be called at the same time. > Currently there's no such sanity check in the iommu core. A poorly > written driver could mess up the kernel by misusing this interface. Yes, I don't think up a scenario except dirty tracking. Indeed, we'd better not make them as a generic interface. Do you have any suggestion that underlying iommu drivers can share these code but not make it as a generic iommu interface? I have a not so good idea. Make the "split" interfaces as a static function, and transfer the function pointer to start_dirty_log. But it looks weird and inflexible. On the other hand, if a driver calls map/unmap with split/merge at the same time, it's a bug of driver, it should follow the rule. > > This also applies to iommu_merge_page(). > Thanks, Keqian From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19727C433ED for ; Mon, 19 Apr 2021 09:32:33 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 79BED6101D for ; Mon, 19 Apr 2021 09:32:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 79BED6101D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 1D93C4038C; Mon, 19 Apr 2021 09:32:32 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id zRxAX9CA0gWv; Mon, 19 Apr 2021 09:32:31 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp4.osuosl.org (Postfix) with ESMTP id CA41940393; Mon, 19 Apr 2021 09:32:29 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 9F6AAC000F; Mon, 19 Apr 2021 09:32:29 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136]) by lists.linuxfoundation.org (Postfix) with ESMTP id 6C754C000B for ; Mon, 19 Apr 2021 09:32:27 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 4C061607CD for ; Mon, 19 Apr 2021 09:32:27 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id aPff8V-pyHGm for ; Mon, 19 Apr 2021 09:32:23 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from szxga05-in.huawei.com (szxga05-in.huawei.com [45.249.212.191]) by smtp3.osuosl.org (Postfix) with ESMTPS id D0492607BF for ; Mon, 19 Apr 2021 09:32:22 +0000 (UTC) Received: from DGGEMS410-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4FP1kD4zpFzqTsr; Mon, 19 Apr 2021 17:29:56 +0800 (CST) Received: from [10.174.187.224] (10.174.187.224) by DGGEMS410-HUB.china.huawei.com (10.3.19.210) with Microsoft SMTP Server id 14.3.498.0; Mon, 19 Apr 2021 17:32:09 +0800 Subject: Re: [PATCH v3 02/12] iommu: Add iommu_split_block interface To: Lu Baolu , , , , Robin Murphy , Will Deacon , "Joerg Roedel" , Yi Sun , "Jean-Philippe Brucker" , Jonathan Cameron , Tian Kevin References: <20210413085457.25400-1-zhukeqian1@huawei.com> <20210413085457.25400-3-zhukeqian1@huawei.com> From: Keqian Zhu Message-ID: <491da550-dc54-42e6-ac91-13d411575fad@huawei.com> Date: Mon, 19 Apr 2021 17:32:08 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: X-Originating-IP: [10.174.187.224] X-CFilter-Loop: Reflected Cc: jiangkunkun@huawei.com, Cornelia Huck , Kirti Wankhede , lushenming@huawei.com, Alex Williamson , wanghaibin.wang@huawei.com X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" Hi Baolu, On 2021/4/14 15:14, Lu Baolu wrote: > On 4/13/21 4:54 PM, Keqian Zhu wrote: >> Block(largepage) mapping is not a proper granule for dirty log tracking. >> Take an extreme example, if DMA writes one byte, under 1G mapping, the >> dirty amount reported is 1G, but under 4K mapping, the dirty amount is >> just 4K. >> >> This adds a new interface named iommu_split_block in IOMMU base layer. >> A specific IOMMU driver can invoke it during start dirty log. If so, the >> driver also need to realize the split_block iommu ops. >> >> We flush all iotlbs after the whole procedure is completed to ease the >> pressure of IOMMU, as we will hanle a huge range of mapping in general. >> >> Signed-off-by: Keqian Zhu >> Signed-off-by: Kunkun Jiang >> --- >> drivers/iommu/iommu.c | 41 +++++++++++++++++++++++++++++++++++++++++ >> include/linux/iommu.h | 11 +++++++++++ >> 2 files changed, 52 insertions(+) >> >> diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c >> index 667b2d6d2fc0..bb413a927870 100644 >> --- a/drivers/iommu/iommu.c >> +++ b/drivers/iommu/iommu.c >> @@ -2721,6 +2721,47 @@ int iommu_domain_set_attr(struct iommu_domain *domain, >> } >> EXPORT_SYMBOL_GPL(iommu_domain_set_attr); >> +int iommu_split_block(struct iommu_domain *domain, unsigned long iova, >> + size_t size) >> +{ >> + const struct iommu_ops *ops = domain->ops; >> + unsigned int min_pagesz; >> + size_t pgsize; >> + bool flush = false; >> + int ret = 0; >> + >> + if (unlikely(!ops || !ops->split_block)) >> + return -ENODEV; >> + >> + min_pagesz = 1 << __ffs(domain->pgsize_bitmap); >> + if (!IS_ALIGNED(iova | size, min_pagesz)) { >> + pr_err("unaligned: iova 0x%lx size 0x%zx min_pagesz 0x%x\n", >> + iova, size, min_pagesz); >> + return -EINVAL; >> + } >> + >> + while (size) { >> + flush = true; >> + >> + pgsize = iommu_pgsize(domain, iova, size); >> + >> + ret = ops->split_block(domain, iova, pgsize); >> + if (ret) >> + break; >> + >> + pr_debug("split handled: iova 0x%lx size 0x%zx\n", iova, pgsize); >> + >> + iova += pgsize; >> + size -= pgsize; >> + } >> + >> + if (flush) >> + iommu_flush_iotlb_all(domain); >> + >> + return ret; >> +} >> +EXPORT_SYMBOL_GPL(iommu_split_block); > > Do you really have any consumers of this interface other than the dirty > bit tracking? If not, I don't suggest to make this as a generic IOMMU > interface. > > There is an implicit requirement for such interfaces. The > iommu_map/unmap(iova, size) shouldn't be called at the same time. > Currently there's no such sanity check in the iommu core. A poorly > written driver could mess up the kernel by misusing this interface. Yes, I don't think up a scenario except dirty tracking. Indeed, we'd better not make them as a generic interface. Do you have any suggestion that underlying iommu drivers can share these code but not make it as a generic iommu interface? I have a not so good idea. Make the "split" interfaces as a static function, and transfer the function pointer to start_dirty_log. But it looks weird and inflexible. On the other hand, if a driver calls map/unmap with split/merge at the same time, it's a bug of driver, it should follow the rule. > > This also applies to iommu_merge_page(). > Thanks, Keqian _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05899C433ED for ; Mon, 19 Apr 2021 09:34:31 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5DDA661027 for ; Mon, 19 Apr 2021 09:34:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5DDA661027 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From:CC: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=R1UhHWc0HwV3IJXFCnqGInwVCC0kaVTHt5LVzs5LXB8=; b=ItArQgWPSxYGSKmsG3+xvzoJ1 hjhhe5RbhGDmaKLyqH8Zm/WhBQlrGoCcN3ihF9hRY+Mn06UV595v38C1U76VlzPN8+sC5oU38c5tt /upRAi4e6kCnYK4kQC+p1DHowfuEIT2hOyCwrEN46vWpLUdGXbrdmz9CHYtJTi/usQvE1EgHRQNqf NZ3tVOWWdWb7a+gF78s8TyYy7oV1ijSdf7qsQk5EyOXq7Tngp/g7gUbGrsiNC5tGLRHrIl/kqEigT U0Ro9UlXj8p2IjjPqyASs/2crsGWz03ZaBpN1PanEysz0Dkt5PSf30J0C1g6f+o73u1+q/ZLqT8m9 LSko9Ockg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lYQGi-009YfV-Fj; Mon, 19 Apr 2021 09:32:36 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lYQGg-009YfK-9y for linux-arm-kernel@desiato.infradead.org; Mon, 19 Apr 2021 09:32:34 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:CC:References:To: Subject:Sender:Reply-To:Content-ID:Content-Description; bh=SOVxLrfQA7v0Mo2piSEsPYvMh7Cm0ARAJRzAaEsfhig=; b=BEKopbSj9sZxirikjeR5yr0V64 lT25PrQk4o1EU8Cd6ac7lI/CWpJkyJEkLzpzPpAQ5/Z7vAZ902CgVSwXZECej/sVrHW92BPuy5lEI IDbGpYXuiBcBnBh20bmrpG+FJJVxt3EpdoAFRBdWciD4xvBA2i2WBrQp9AoZp+RF+0wLcqOg+WF5i hjgTMVeeVU+08UECddEVRfFfMo3SO9FgES0GafBk1KZoQ0u+guzq8t5gUmLFJfhMIgobZ1HxA/74y 7mC0GxfEvvTqzyhCPDi2IdzZWEQAhLG1qvVbT/ZF+s+beVACYD94Ex5dvQ9oGgw4mKoSvLG/x7V7W j0E1LX2w==; Received: from szxga05-in.huawei.com ([45.249.212.191]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lYQGa-00BEMy-4z for linux-arm-kernel@lists.infradead.org; Mon, 19 Apr 2021 09:32:33 +0000 Received: from DGGEMS410-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4FP1kD4zpFzqTsr; Mon, 19 Apr 2021 17:29:56 +0800 (CST) Received: from [10.174.187.224] (10.174.187.224) by DGGEMS410-HUB.china.huawei.com (10.3.19.210) with Microsoft SMTP Server id 14.3.498.0; Mon, 19 Apr 2021 17:32:09 +0800 Subject: Re: [PATCH v3 02/12] iommu: Add iommu_split_block interface To: Lu Baolu , , , , Robin Murphy , Will Deacon , "Joerg Roedel" , Yi Sun , "Jean-Philippe Brucker" , Jonathan Cameron , Tian Kevin References: <20210413085457.25400-1-zhukeqian1@huawei.com> <20210413085457.25400-3-zhukeqian1@huawei.com> CC: Alex Williamson , Cornelia Huck , Kirti Wankhede , , , , From: Keqian Zhu Message-ID: <491da550-dc54-42e6-ac91-13d411575fad@huawei.com> Date: Mon, 19 Apr 2021 17:32:08 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: X-Originating-IP: [10.174.187.224] X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210419_023228_555677_510879AA X-CRM114-Status: GOOD ( 25.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Baolu, On 2021/4/14 15:14, Lu Baolu wrote: > On 4/13/21 4:54 PM, Keqian Zhu wrote: >> Block(largepage) mapping is not a proper granule for dirty log tracking. >> Take an extreme example, if DMA writes one byte, under 1G mapping, the >> dirty amount reported is 1G, but under 4K mapping, the dirty amount is >> just 4K. >> >> This adds a new interface named iommu_split_block in IOMMU base layer. >> A specific IOMMU driver can invoke it during start dirty log. If so, the >> driver also need to realize the split_block iommu ops. >> >> We flush all iotlbs after the whole procedure is completed to ease the >> pressure of IOMMU, as we will hanle a huge range of mapping in general. >> >> Signed-off-by: Keqian Zhu >> Signed-off-by: Kunkun Jiang >> --- >> drivers/iommu/iommu.c | 41 +++++++++++++++++++++++++++++++++++++++++ >> include/linux/iommu.h | 11 +++++++++++ >> 2 files changed, 52 insertions(+) >> >> diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c >> index 667b2d6d2fc0..bb413a927870 100644 >> --- a/drivers/iommu/iommu.c >> +++ b/drivers/iommu/iommu.c >> @@ -2721,6 +2721,47 @@ int iommu_domain_set_attr(struct iommu_domain *domain, >> } >> EXPORT_SYMBOL_GPL(iommu_domain_set_attr); >> +int iommu_split_block(struct iommu_domain *domain, unsigned long iova, >> + size_t size) >> +{ >> + const struct iommu_ops *ops = domain->ops; >> + unsigned int min_pagesz; >> + size_t pgsize; >> + bool flush = false; >> + int ret = 0; >> + >> + if (unlikely(!ops || !ops->split_block)) >> + return -ENODEV; >> + >> + min_pagesz = 1 << __ffs(domain->pgsize_bitmap); >> + if (!IS_ALIGNED(iova | size, min_pagesz)) { >> + pr_err("unaligned: iova 0x%lx size 0x%zx min_pagesz 0x%x\n", >> + iova, size, min_pagesz); >> + return -EINVAL; >> + } >> + >> + while (size) { >> + flush = true; >> + >> + pgsize = iommu_pgsize(domain, iova, size); >> + >> + ret = ops->split_block(domain, iova, pgsize); >> + if (ret) >> + break; >> + >> + pr_debug("split handled: iova 0x%lx size 0x%zx\n", iova, pgsize); >> + >> + iova += pgsize; >> + size -= pgsize; >> + } >> + >> + if (flush) >> + iommu_flush_iotlb_all(domain); >> + >> + return ret; >> +} >> +EXPORT_SYMBOL_GPL(iommu_split_block); > > Do you really have any consumers of this interface other than the dirty > bit tracking? If not, I don't suggest to make this as a generic IOMMU > interface. > > There is an implicit requirement for such interfaces. The > iommu_map/unmap(iova, size) shouldn't be called at the same time. > Currently there's no such sanity check in the iommu core. A poorly > written driver could mess up the kernel by misusing this interface. Yes, I don't think up a scenario except dirty tracking. Indeed, we'd better not make them as a generic interface. Do you have any suggestion that underlying iommu drivers can share these code but not make it as a generic iommu interface? I have a not so good idea. Make the "split" interfaces as a static function, and transfer the function pointer to start_dirty_log. But it looks weird and inflexible. On the other hand, if a driver calls map/unmap with split/merge at the same time, it's a bug of driver, it should follow the rule. > > This also applies to iommu_merge_page(). > Thanks, Keqian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel