From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0A06FC678D4 for ; Mon, 6 Mar 2023 14:30:05 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pZBqY-0001ap-4a; Mon, 06 Mar 2023 09:29:50 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pZBqV-0001Xz-C7; Mon, 06 Mar 2023 09:29:48 -0500 Received: from forwardcorp1b.mail.yandex.net ([178.154.239.136]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pZBqT-0004IV-D9; Mon, 06 Mar 2023 09:29:46 -0500 Received: from mail-nwsmtp-smtp-corp-main-62.myt.yp-c.yandex.net (mail-nwsmtp-smtp-corp-main-62.myt.yp-c.yandex.net [IPv6:2a02:6b8:c12:57a5:0:640:1f49:0]) by forwardcorp1b.mail.yandex.net (Yandex) with ESMTP id CBB255FDD7; Mon, 6 Mar 2023 17:29:35 +0300 (MSK) Received: from [IPV6:2a02:6b8:b081:b71c::1:25] (unknown [2a02:6b8:b081:b71c::1:25]) by mail-nwsmtp-smtp-corp-main-62.myt.yp-c.yandex.net (smtpcorp/Yandex) with ESMTPSA id YTbfR10OcGk0-PMpp6JQp; Mon, 06 Mar 2023 17:29:35 +0300 X-Yandex-Fwd: 1 Authentication-Results: mail-nwsmtp-smtp-corp-main-62.myt.yp-c.yandex.net; dkim=pass Message-ID: <491fa865-a40b-7f91-7505-f80819b07d7a@yandex-team.ru> Date: Mon, 6 Mar 2023 17:29:34 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH 00/43] Migration: Create options.c for capabilities/params/properties Content-Language: en-US To: Juan Quintela , qemu-devel@nongnu.org Cc: David Hildenbrand , John Snow , Stefan Hajnoczi , qemu-block@nongnu.org, Hailiang Zhang , Fam Zheng , "Michael S. Tsirkin" , "Dr. David Alan Gilbert" , Eric Blake References: <20230302163410.11399-1-quintela@redhat.com> From: Vladimir Sementsov-Ogievskiy In-Reply-To: <20230302163410.11399-1-quintela@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=178.154.239.136; envelope-from=vsementsov@yandex-team.ru; helo=forwardcorp1b.mail.yandex.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 02.03.23 19:33, Juan Quintela wrote: > Hi > > This series move to options.c: > - all migration capabilities code > - all migration parameters code > - all properties code > - all qmp commands that only touch the previous > > And once there: > - sort of functions > - make consistent and coherent all the functions naming/typing > - create accessors for the parameters/capabilties that don't exist > - more cleanups here and there. > > Todo: > > - There is still capabilities code on savevm.c, but I want this in > before moving that code to options.c, but still needs more thought > for my part. I.e. should I put vmstate sections in options.c, or > should I create new functions to access the capabilities in savevm.c. > > Please review. Hmm, I can't apply to current master, neither can patchew: https://patchew.org/QEMU/20230302163410.11399-1-quintela@redhat.com/ On which commit the series based on? -- Best regards, Vladimir