All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: Ming Lei <ming.lei@redhat.com>, Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org,
	Damien Le Moal <Damien.LeMoal@wdc.com>,
	syzbot+da3b7677bb913dc1b737@syzkaller.appspotmail.com
Subject: Re: [PATCH] blk-mq: move lockdep_assert_held() into elevator_exit
Date: Wed, 25 Sep 2019 16:31:59 -0700	[thread overview]
Message-ID: <492f8cb4-2fbe-2c34-4792-7cc56f81a14a@acm.org> (raw)
In-Reply-To: <20190925222354.26152-1-ming.lei@redhat.com>

On 9/25/19 3:23 PM, Ming Lei wrote:
> Commit c48dac137a62 ("block: don't hold q->sysfs_lock in elevator_init_mq")
> removes q->sysfs_lock from elevator_init_mq(), but forgot to deal with
> lockdep_assert_held() called in blk_mq_sched_free_requests() which is
> run in failure path of elevator_init_mq().
> 
> blk_mq_sched_free_requests() is called in the following 3 functions:
> 
> 	elevator_init_mq()
> 	elevator_exit()
> 	blk_cleanup_queue()
> 
> In blk_cleanup_queue(), blk_mq_sched_free_requests() is followed exactly
> by 'mutex_lock(&q->sysfs_lock)'.
> 
> So moving the lockdep_assert_held() from blk_mq_sched_free_requests()
> into elevator_exit() for fixing the report by syzbot.

Reviewed-by: Bart Van Assche <bvanassche@acm.org>

  reply	other threads:[~2019-09-25 23:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-25 22:23 [PATCH] blk-mq: move lockdep_assert_held() into elevator_exit Ming Lei
2019-09-25 23:31 ` Bart Van Assche [this message]
2019-09-25 23:38 ` Damien Le Moal
2019-09-26  6:45 ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=492f8cb4-2fbe-2c34-4792-7cc56f81a14a@acm.org \
    --to=bvanassche@acm.org \
    --cc=Damien.LeMoal@wdc.com \
    --cc=axboe@kernel.dk \
    --cc=linux-block@vger.kernel.org \
    --cc=ming.lei@redhat.com \
    --cc=syzbot+da3b7677bb913dc1b737@syzkaller.appspotmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.