From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [RFC 1/7] drm/omap: Use devm_kzalloc() to allocate omap_drm_private Date: Fri, 01 Sep 2017 14:10:34 +0300 Message-ID: <4935903.PPgScnvqmu@avalon> References: <20170829073218.11097-1-peter.ujfalusi@ti.com> <20170829073218.11097-2-peter.ujfalusi@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from galahad.ideasonboard.com (galahad.ideasonboard.com [185.26.127.97]) by gabe.freedesktop.org (Postfix) with ESMTPS id A88168996E for ; Fri, 1 Sep 2017 13:13:06 +0000 (UTC) In-Reply-To: <20170829073218.11097-2-peter.ujfalusi@ti.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Peter Ujfalusi Cc: tomi.valkeinen@ti.com, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org SGkgUGV0ZXIsCgpUaGFuayB5b3UgZm9yIHRoZSBwYXRjaC4KCk9uIFR1ZXNkYXksIDI5IEF1Z3Vz dCAyMDE3IDEwOjMyOjEyIEVFU1QgUGV0ZXIgVWpmYWx1c2kgd3JvdGU6Cj4gSXQgbWFrZXMgdGhl IGNsZWFudXAgcGF0aHMgYSBiaXQgY2xlYW5lci4KCkJ1dCBpdCBhbHNvIGdvZXMgYWdhaW5zdCBh IHByb3BlciBpbXBsZW1lbnRhdGlvbiBvZiBvYmplY3QgbGlmZXRpbWUgbWFuYWdlbWVudCAKOi0o IEluIERSTSBkcml2ZXIgcHJpdmF0ZSBzdHJ1Y3R1cmVzIGFyZSBhY2Nlc3NpYmxlIGZyb20gZmls ZSBvcGVyYXRpb25zLCBhbmQgCm11c3QgdGh1cyBiZSByZWZlcmVuY2UtY291bnRlZCBhbmQgb25s eSBmcmVlZCB3aGVuIHRoZSBsYXN0IHVzZXJzcGFjZSB1c2VyIApnb2VzIGF3YXkuIFRoaXMgbWF5 IGJlIGFmdGVyIHRoZSBkZXZtXyogcmVzb3VyY2VzIGFyZSByZWxlYXNlZCByaWdodCBhZnRlciB0 aGUgCi5yZW1vdmUoKSBvcGVyYXRpb24gaXMgY2FsbGVkLiBVc2luZyBkZXZtX2t6YWxsb2MoKSB3 b3VsZCB0aHVzIG1ha2UgaXQgCmltcG9zc2libGUgdG8gcHJvcGVybHkgcmVmZXJlbmNlLWNvdW50 IG91ciBkYXRhIHN0cnVjdHVyZXMuCgo+IFNpZ25lZC1vZmYtYnk6IFBldGVyIFVqZmFsdXNpIDxw ZXRlci51amZhbHVzaUB0aS5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9vbWFwZHJtL29t YXBfZHJ2LmMgfCAxOSArKysrKysrLS0tLS0tLS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCA3IGlu c2VydGlvbnMoKyksIDEyIGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dw dS9kcm0vb21hcGRybS9vbWFwX2Rydi5jCj4gYi9kcml2ZXJzL2dwdS9kcm0vb21hcGRybS9vbWFw X2Rydi5jIGluZGV4IDliM2MzNmI0ODM1Ni4uOTAzNTEwZDgwNTRlCj4gMTAwNjQ0Cj4gLS0tIGEv ZHJpdmVycy9ncHUvZHJtL29tYXBkcm0vb21hcF9kcnYuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2Ry bS9vbWFwZHJtL29tYXBfZHJ2LmMKPiBAQCAtNTQ4LDE5ICs1NDgsMTcgQEAgc3RhdGljIGludCBw ZGV2X3Byb2JlKHN0cnVjdCBwbGF0Zm9ybV9kZXZpY2UgKnBkZXYpCj4gIAkJcmV0dXJuIHJldDsK PiAgCX0KPiAKPiArCXByaXYgPSBkZXZtX2t6YWxsb2MoJnBkZXYtPmRldiwgc2l6ZW9mKCpwcml2 KSwgR0ZQX0tFUk5FTCk7Cj4gKwlpZiAoIXByaXYpCj4gKwkJcmV0dXJuIC1FTk9NRU07Cj4gKwo+ ICAJb21hcF9jcnRjX3ByZV9pbml0KCk7Cj4gCj4gIAlyZXQgPSBvbWFwX2Nvbm5lY3RfZHNzZGV2 cygpOwo+ICAJaWYgKHJldCkKPiAgCQlnb3RvIGVycl9jcnRjX3VuaW5pdDsKPiAKPiAtCS8qIEFs bG9jYXRlIGFuZCBpbml0aWFsaXplIHRoZSBkcml2ZXIgcHJpdmF0ZSBzdHJ1Y3R1cmUuICovCj4g LQlwcml2ID0ga3phbGxvYyhzaXplb2YoKnByaXYpLCBHRlBfS0VSTkVMKTsKPiAtCWlmICghcHJp dikgewo+IC0JCXJldCA9IC1FTk9NRU07Cj4gLQkJZ290byBlcnJfZGlzY29ubmVjdF9kc3NkZXZz Owo+IC0JfQo+IC0KPiArCS8qIEluaXRpYWxpemUgdGhlIGRyaXZlciBwcml2YXRlIHN0cnVjdHVy ZS4gKi8KPiAgCXByaXYtPmRpc3BjX29wcyA9IGRpc3BjX2dldF9vcHMoKTsKPiAKPiAgCXNvYyA9 IHNvY19kZXZpY2VfbWF0Y2gob21hcGRybV9zb2NfZGV2aWNlcyk7Cj4gQEAgLTU3NCw3ICs1NzIs NyBAQCBzdGF0aWMgaW50IHBkZXZfcHJvYmUoc3RydWN0IHBsYXRmb3JtX2RldmljZSAqcGRldikK PiAgCWRkZXYgPSBkcm1fZGV2X2FsbG9jKCZvbWFwX2RybV9kcml2ZXIsICZwZGV2LT5kZXYpOwo+ ICAJaWYgKElTX0VSUihkZGV2KSkgewo+ICAJCXJldCA9IFBUUl9FUlIoZGRldik7Cj4gLQkJZ290 byBlcnJfZnJlZV9wcml2Owo+ICsJCWdvdG8gZXJyX2Rlc3Ryb3lfd3E7Cj4gIAl9Cj4gCj4gIAlk ZGV2LT5kZXZfcHJpdmF0ZSA9IHByaXY7Cj4gQEAgLTYyNCwxMCArNjIyLDggQEAgc3RhdGljIGlu dCBwZGV2X3Byb2JlKHN0cnVjdCBwbGF0Zm9ybV9kZXZpY2UgKnBkZXYpCj4gIGVycl9mcmVlX2Ry bV9kZXY6Cj4gIAlvbWFwX2dlbV9kZWluaXQoZGRldik7Cj4gIAlkcm1fZGV2X3VucmVmKGRkZXYp Owo+IC1lcnJfZnJlZV9wcml2Ogo+ICtlcnJfZGVzdHJveV93cToKPiAgCWRlc3Ryb3lfd29ya3F1 ZXVlKHByaXYtPndxKTsKPiAtCWtmcmVlKHByaXYpOwo+IC1lcnJfZGlzY29ubmVjdF9kc3NkZXZz Ogo+ICAJb21hcF9kaXNjb25uZWN0X2Rzc2RldnMoKTsKPiAgZXJyX2NydGNfdW5pbml0Ogo+ICAJ b21hcF9jcnRjX3ByZV91bmluaXQoKTsKPiBAQCAtNjU5LDcgKzY1NSw2IEBAIHN0YXRpYyBpbnQg cGRldl9yZW1vdmUoc3RydWN0IHBsYXRmb3JtX2RldmljZSAqcGRldikKPiAgCWRybV9kZXZfdW5y ZWYoZGRldik7Cj4gCj4gIAlkZXN0cm95X3dvcmtxdWV1ZShwcml2LT53cSk7Cj4gLQlrZnJlZShw cml2KTsKPiAKPiAgCW9tYXBfZGlzY29ubmVjdF9kc3NkZXZzKCk7Cj4gIAlvbWFwX2NydGNfcHJl X3VuaW5pdCgpOwoKCi0tIApSZWdhcmRzLAoKTGF1cmVudCBQaW5jaGFydAoKX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlz dApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0 b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==