Re: [PATCH 3/3] f2fs: quota: fix incorrect error message and comments

[Sheng Yong <shengyong1@huawei.com>]

On 2018/7/25 23:44, Chao Yu wrote:
> On 2018/7/24 20:17, Sheng Yong wrote:
>> Signed-off-by: Sheng Yong <shengyong1@huawei.com>
>> ---
>>   fs/f2fs/checkpoint.c | 5 ++++-
>>   fs/f2fs/recovery.c   | 2 +-
>>   fs/f2fs/super.c      | 5 +----
>>   3 files changed, 6 insertions(+), 6 deletions(-)
>>
>> diff --git a/fs/f2fs/checkpoint.c b/fs/f2fs/checkpoint.c
>> index 9c29526a7633..9a0222d9e28c 100644
>> --- a/fs/f2fs/checkpoint.c
>> +++ b/fs/f2fs/checkpoint.c
>> @@ -645,7 +645,10 @@ int f2fs_recover_orphan_inodes(struct f2fs_sb_info *sbi)
>>   	/* Needed for iput() to work correctly and not trash data */
>>   	sbi->sb->s_flags |= SB_ACTIVE;
>>   
>> -	/* Turn on quotas so that they are updated correctly */
>> +	/*
>> +	 * Turn on quotas which were not enabled for read-only mounts if
>> +	 * filesystem has quota feature, so that they are updated correctly.
>> +	 */
>>   	quota_enabled = f2fs_enable_quota_files(sbi, s_flags & SB_RDONLY);
>>   #endif
>>   
>> diff --git a/fs/f2fs/recovery.c b/fs/f2fs/recovery.c
>> index 0d927ae26c48..e93162a2e6d8 100644
>> --- a/fs/f2fs/recovery.c
>> +++ b/fs/f2fs/recovery.c
>> @@ -628,7 +628,7 @@ int f2fs_recover_fsync_data(struct f2fs_sb_info *sbi, bool check_only)
>>   #endif
>>   
>>   	if (s_flags & SB_RDONLY) {
>> -		f2fs_msg(sbi->sb, KERN_INFO, "orphan cleanup on readonly fs");
>> +		f2fs_msg(sbi->sb, KERN_INFO, "fsync data recover on readonly fs");
> 
> I remember Yunlei has fix this print info in another patch.
> 

Hi, Chao,

I checked the list just now, yes, Yunlei has already submitted a patch to fix
the error message. Please ignore this :)

thanks

> Thanks,
> 
>>   		sbi->sb->s_flags &= ~SB_RDONLY;
>>   	}
>>   
>> diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
>> index 4ed91ceab3ee..3e24dde60f54 100644
>> --- a/fs/f2fs/super.c
>> +++ b/fs/f2fs/super.c
>> @@ -2970,10 +2970,7 @@ static int f2fs_fill_super(struct super_block *sb, void *data, int silent)
>>   		goto free_root_inode;
>>   
>>   #ifdef CONFIG_QUOTA
>> -	/*
>> -	 * Turn on quotas which were not enabled for read-only mounts if
>> -	 * filesystem has quota feature, so that they are updated correctly.
>> -	 */
>> +	/* Enable quota usage during mount */
>>   	if (f2fs_sb_has_quota_ino(sb) && !f2fs_readonly(sb)) {
>>   		err = f2fs_enable_quotas(sb);
>>   		if (err) {
>>
> 
> .
> 


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot