From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1L93bl-0000hh-73 for mharc-grub-devel@gnu.org; Sat, 06 Dec 2008 15:18:33 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1L93bj-0000hB-FI for grub-devel@gnu.org; Sat, 06 Dec 2008 15:18:31 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1L93bh-0000gt-VB for grub-devel@gnu.org; Sat, 06 Dec 2008 15:18:31 -0500 Received: from [199.232.76.173] (port=53379 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L93bh-0000go-PA for grub-devel@gnu.org; Sat, 06 Dec 2008 15:18:29 -0500 Received: from mta-out.inet.fi ([195.156.147.13]:51633 helo=jenni2.inet.fi) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1L93bg-00084n-Gu for grub-devel@gnu.org; Sat, 06 Dec 2008 15:18:28 -0500 Received: from [192.168.1.102] (84.248.105.254) by jenni2.inet.fi (8.5.014) id 48FC5A880226E9A2 for grub-devel@gnu.org; Sat, 6 Dec 2008 22:18:22 +0200 Message-ID: <493ADE06.7080001@nic.fi> Date: Sat, 06 Dec 2008 22:18:14 +0200 From: =?ISO-8859-1?Q?Vesa_J=E4=E4skel=E4inen?= User-Agent: Thunderbird 2.0.0.18 (Windows/20081105) MIME-Version: 1.0 To: grub-devel@gnu.org References: <20080901092753.3918cf73@gamma.lan> <20081004214640.5ab21f53@gibibit.com> <48E87FB9.8070603@nic.fi> <20081030121106.4efffecc@gibibit.com> <20081030205736.7e080a5e@gibibit.com> In-Reply-To: <20081030205736.7e080a5e@gibibit.com> X-Enigmail-Version: 0.95.7 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: Quoted-Printable X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Subject: Re: [PATCH] GSoC #10 new font engine (UTF-8 support+bugfix) X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Dec 2008 20:18:31 -0000 Colin D Bennett wrote: > Update:=20 >=20 > I fixed an error pointed out to me by Y.Volta:=20 > In grub_font_get(), if no fonts are loaded, a null pointer is > dereferenced. This is fixed in the attached patch. >=20 > The grub_font_get() function now returns a dummy font object (a > statically allocated font object with no characters) so that callers of > grub_font_get() can be assured that the return value will never be > NULL. If no fonts are loaded, then the "unknown glyph" will be used > for all characters, but it will be safe. Hi Colin, I applied this patch against SVN today and tried it out. And noticed that gfxterm gets a bit "broken" after this. Was this the thing that I promised to look at :) ? Or was my merge just incomplete? Videotest was fine however. (or how fine it can be with just unifont.bdf) After: loadfont /boot/grub/unifont.pf2 lsfonts gives: Loaded fonts: Unknown -1 Is this expected? Thanks, Vesa J=E4=E4skel=E4inen