All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Hildenbrand <david@redhat.com>
To: Cornelia Huck <cohuck@redhat.com>
Cc: qemu-s390x@nongnu.org, qemu-devel@nongnu.org,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	Richard Henderson <rth@twiddle.net>,
	Alexander Graf <agraf@suse.de>, Thomas Huth <thuth@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 00/18] s390x: flic rework, tcg flic support and STSI
Date: Thu, 25 Jan 2018 14:11:29 +0100	[thread overview]
Message-ID: <493ef7b2-a8cf-2231-e8b0-e8adef21b47a@redhat.com> (raw)
In-Reply-To: <20180125134740.3a1c4bbb.cohuck@redhat.com>

On 25.01.2018 13:47, Cornelia Huck wrote:
> On Thu, 25 Jan 2018 13:42:41 +0100
> Cornelia Huck <cohuck@redhat.com> wrote:
> 
>> On Wed, 17 Jan 2018 18:40:29 +0100
>> David Hildenbrand <david@redhat.com> wrote:
>>
>>> This patch series implements floating interrupt support for TCG and fixes
>>> STSI so we can remove warnings related to s390x SMP and MTTCG.
>>>
>>> KVM code has to be touched in order to factor out the injection routines
>>> into the flic ("s390x/flic: factor out injection of floating interrupts").
>>> Basic testing didn't reveal any problems so far.
>>>
>>> With this series I am now able to run fedora 26/27 and Ubuntu 17.10+ with
>>> 16 VCPUs (MTTCG) on a 8CPU host, doing a make -j16 in the guest. I got
>>> nasty stalls in the guest beforehand.
>>>
>>> Now also included: More flic related caching to avoid recurring
>>> conversions.  
>>
>> Hm...
>>
>> (qemu) device_add virtio-net-ccw,id=xxx
>> (qemu) **
>> ERROR:/home/cohuck/git/qemu/target/s390x/excp_helper.c:342:do_mchk_interrupt: assertion failed: (env->cregs[14] & CR0_SERVICE_SC)
>> Aborted (core dumped)
> 
> Works much better if you check for CR14_CHANNEL_REPORT_SC instead :)
> 

Thanks for testing and spotting the wrong assert!

-- 

Thanks,

David / dhildenb

  reply	other threads:[~2018-01-25 13:11 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-17 17:40 [Qemu-devel] [PATCH v2 00/18] s390x: flic rework, tcg flic support and STSI David Hildenbrand
2018-01-17 17:40 ` [Qemu-devel] [PATCH v2 01/18] s390x/tcg: deliver multiple interrupts in a row David Hildenbrand
2018-01-17 17:40 ` [Qemu-devel] [PATCH v2 02/18] s390x/flic: simplify flic initialization David Hildenbrand
2018-01-17 17:40 ` [Qemu-devel] [PATCH v2 03/18] s390x/tcg: simplify lookup of flic David Hildenbrand
2018-01-17 17:40 ` [Qemu-devel] [PATCH v2 04/18] s390x/tcg: simplify machine check handling David Hildenbrand
2018-01-17 17:40 ` [Qemu-devel] [PATCH v2 05/18] s390x/flic: factor out injection of floating interrupts David Hildenbrand
2018-01-17 17:40 ` [Qemu-devel] [PATCH v2 06/18] s390x/flic: no need to call s390_io_interrupt() from flic David Hildenbrand
2018-01-17 17:40 ` [Qemu-devel] [PATCH v2 07/18] s390x/tcg: tolerate wrong wakeups due to floating interrupts David Hildenbrand
2018-01-25 10:22   ` Cornelia Huck
2018-01-17 17:40 ` [Qemu-devel] [PATCH v2 08/18] s390x/flic: make floating interrupts on TCG actually floating David Hildenbrand
2018-01-17 17:40 ` [Qemu-devel] [PATCH v2 09/18] s390x/tcg: implement TEST PENDING INTERRUPTION David Hildenbrand
2018-01-17 17:40 ` [Qemu-devel] [PATCH v2 10/18] s390x/flic: implement qemu_s390_clear_io_flic() David Hildenbrand
2018-01-17 17:40 ` [Qemu-devel] [PATCH v2 11/18] s390x/flic: optimize CPU wakeup for TCG David Hildenbrand
2018-01-17 17:40 ` [Qemu-devel] [PATCH v2 12/18] s390x: fix size + content of STSI blocks David Hildenbrand
2018-01-25 10:26   ` Cornelia Huck
2018-01-25 13:15     ` David Hildenbrand
2018-01-25 13:51       ` Cornelia Huck
2018-01-29  9:42         ` [Qemu-devel] [qemu-s390x] " David Hildenbrand
2018-01-29  9:48           ` Cornelia Huck
2018-01-17 17:40 ` [Qemu-devel] [PATCH v2 13/18] s390x/tcg: STSI overhaul David Hildenbrand
2018-01-17 17:40 ` [Qemu-devel] [PATCH v2 14/18] s390x/tcg: remove SMP warning David Hildenbrand
2018-01-17 17:40 ` [Qemu-devel] [PATCH v2 15/18] configure: s390x supports mttcg now David Hildenbrand
2018-01-17 17:40 ` [Qemu-devel] [PATCH v2 16/18] s390x/tcg: cache the qemu flic in a central function David Hildenbrand
2018-01-17 17:40 ` [Qemu-devel] [PATCH v2 17/18] s390x/kvm: cache the kvm " David Hildenbrand
2018-01-25 11:03   ` Christian Borntraeger
2018-01-17 17:40 ` [Qemu-devel] [PATCH v2 18/18] s390x/flic: cache the common flic class " David Hildenbrand
2018-01-25 10:29 ` [Qemu-devel] [PATCH v2 00/18] s390x: flic rework, tcg flic support and STSI Cornelia Huck
2018-01-25 12:42 ` Cornelia Huck
2018-01-25 12:47   ` Cornelia Huck
2018-01-25 13:11     ` David Hildenbrand [this message]
2018-01-25 13:13       ` Thomas Huth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=493ef7b2-a8cf-2231-e8b0-e8adef21b47a@redhat.com \
    --to=david@redhat.com \
    --cc=agraf@suse.de \
    --cc=borntraeger@de.ibm.com \
    --cc=cohuck@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-s390x@nongnu.org \
    --cc=rth@twiddle.net \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.