All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heinrich Schuchardt <xypron.glpk@gmx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] crypto/fsl: instantiate all rng state handles
Date: Thu, 25 Jan 2018 17:53:21 +0100	[thread overview]
Message-ID: <494b7167-73e2-3e2d-b5cd-5ec9e13d53fc@gmx.de> (raw)
In-Reply-To: <a7aeb47e-813f-a678-32da-ecc2c08abfe0@linaro.org>

On 01/25/2018 04:53 PM, Bryan O'Donoghue wrote:
> 
> 
> On 25/01/18 13:11, Lukas Auer wrote:
>> Extend the instantiate_rng() function and the corresponding CAAM job
>> descriptor to instantiate all RNG state handles. This moves the RNG
>> instantiation code in line with the CAAM kernel driver.
>>
>> Previously, only the first state handle was instantiated. The second one
>> was instantiated by the CAAM kernel driver. This works if the kernel
>> runs in secure mode, but fails in non-secure mode since the kernel
>> driver uses DEC0 directly instead of over the job ring interface.
>> Instantiating all RNG state handles in u-boot removes the need for using
>> DEC0 in the kernel driver, making it possible to use the CAAM in
>> non-secure mode.
>>
>> Signed-off-by: Lukas Auer <lukas.auer@aisec.fraunhofer.de>
> 
> git apply < \[PATCH\]\ crypto_fsl\:\ instantiate\ all\ rng\ state\
> handles.eml
> <stdin>:107: trailing whitespace.
> void inline_cnstr_jobdesc_rng_instantiation(uint32_t *desc, int handle)
> <stdin>:130: trailing whitespace.
>             (handle << OP_ALG_AAI_SHIFT) | OP_ALG_AS_INIT);
> <stdin>:131: trailing whitespace.
> 
> <stdin>:132: trailing whitespace.
>     /* For SH0, Secure Keys must be generated as well */
> <stdin>:133: trailing whitespace.
>     if (handle == 0) {
> error: patch failed: drivers/crypto/fsl/jobdesc.c:257
> error: drivers/crypto/fsl/jobdesc.c: patch does not apply
> error: patch failed: drivers/crypto/fsl/jobdesc.h:40
> error: drivers/crypto/fsl/jobdesc.h: patch does not apply
> error: patch failed: drivers/crypto/fsl/jr.c:444
> error: drivers/crypto/fsl/jr.c: patch does not apply
> error: patch failed: drivers/crypto/fsl/jr.h:40
> error: drivers/crypto/fsl/jr.h: patch does not apply
> error: patch failed: include/fsl_sec.h:67
> error: include/fsl_sec.h: patch does not apply

The patch provided by Lukas is applicable to git HEAD
(fb4413295c765aa8c013650984dc2d908964c81d).

File MAINTAINERS does not indicate another git repository for
drivers/crypto/fsl/jobdesc.c.

Pleae, rebase your local repository.

Best regards

Heinrich

> 
> git show HEAD
> commit c761a7e29d703d60208585bb7d8415e00aa22556
> Author: Tom Rini <trini@konsulko.com>
> Date:   Mon Jan 22 21:06:41 2018 -0500
> 
>     Revert "travis-ci: Add qemu-x86_64 target"
> 
> 

  parent reply	other threads:[~2018-01-25 16:53 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-25 13:11 [U-Boot] [PATCH] crypto/fsl: instantiate all rng state handles Lukas Auer
2018-01-25 15:53 ` Bryan O'Donoghue
2018-01-25 16:11   ` Bryan O'Donoghue
2018-01-25 16:21   ` Auer, Lukas
2018-01-25 16:53   ` Heinrich Schuchardt [this message]
2018-01-26  2:09 ` Bryan O'Donoghue
2018-02-12 22:40 ` York Sun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=494b7167-73e2-3e2d-b5cd-5ec9e13d53fc@gmx.de \
    --to=xypron.glpk@gmx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.