From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LFDAC-0008OU-B2 for qemu-devel@nongnu.org; Tue, 23 Dec 2008 14:43:32 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LFDAA-0008Nh-K7 for qemu-devel@nongnu.org; Tue, 23 Dec 2008 14:43:31 -0500 Received: from [199.232.76.173] (port=47757 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LFDAA-0008Na-FB for qemu-devel@nongnu.org; Tue, 23 Dec 2008 14:43:30 -0500 Received: from mail.gmx.net ([213.165.64.20]:35630) by monty-python.gnu.org with smtp (Exim 4.60) (envelope-from ) id 1LFDA9-0006zm-Op for qemu-devel@nongnu.org; Tue, 23 Dec 2008 14:43:30 -0500 Message-ID: <49513F5C.1010605@gmx.net> Date: Tue, 23 Dec 2008 20:43:24 +0100 From: Carl-Daniel Hailfinger MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] Floppy: Remove Sense Interrupt Hack References: <937963.51173.qm@web51111.mail.re2.yahoo.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: theburner1@yahoo.com On 23.12.2008 19:30, Blue Swirl wrote: > On 12/23/08, Justin Chevrier wrote: > >> It also appears that the code referenced in the link loops infinitely due to a missing: "max_sensei--;" which is present in the Linux Kernel's equivalent code. >> > > This one: > http://fxr.watson.org/fxr/source/drivers/block/floppy.c?v=linux-2.4.22;im=bigexcerpts#L1800 > > Adding max_sensei-- to OpenBIOS allows it to survive your previous > patch, which caused an infinite loop earlier: > > floppy_motor_off > SENSEI c0 00 > SENSEI c0 00 > SENSEI c0 00 > SENSEI c0 00 > status = 80, reply_buffer= c0 0 > Can you send a patch for this issue to upstream OpenBIOS? Thanks! Regards, Carl-Daniel -- http://www.hailfinger.org/