From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754694AbYL0TLd (ORCPT ); Sat, 27 Dec 2008 14:11:33 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753547AbYL0TLU (ORCPT ); Sat, 27 Dec 2008 14:11:20 -0500 Received: from fg-out-1718.google.com ([72.14.220.159]:26647 "EHLO fg-out-1718.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753389AbYL0TLT (ORCPT ); Sat, 27 Dec 2008 14:11:19 -0500 Message-ID: <49567dd3.0b38560a.3c6c.0511@mx.google.com> Date: Sat, 27 Dec 2008 20:11:11 +0100 To: Randy Dunlap Cc: David Miller , netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <20081226115921.bb094c58.rdunlap@xenotime.net> References: <20081222191259.11807.53190.stgit@vmbox.hanneseder.net> <20081222191517.11807.20718.stgit@vmbox.hanneseder.net> <20081225.161740.10052019.davem@davemloft.net> <20081226115921.bb094c58.rdunlap@xenotime.net> Subject: Re: [PATCH 03/27] drivers/net: fix sparse warning: returning void-valued expression From: Hannes Eder Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/26/08, Randy Dunlap wrote: > On Thu, 25 Dec 2008 16:17:40 -0800 (PST) > > David Miller wrote: > > > > From: Hannes Eder > > Date: Mon, 22 Dec 2008 20:15:17 +0100 > > > > > Fix this sparse warning: > > > > > > drivers/net/niu.c:8850:2: warning: returning void-valued expression > > > > > > Signed-off-by: Hannes Eder > > > > Can we just fix sparse not to generate this warning? It's > > marginal, at best. C++ even explicitly defines this as valid > > and last time I brought this up Linus even agreed. > > > Ack, I discussed it with him also and he thought that > they were just fine as they were... > > > > The types match, the function returns void and it is returning a void, > > what is the problem? In fact there is no need to _fix_ sparse, as there is a command line option -Wreturn-void / -Wno-return-void, so we could change the Makefile, see diff below. --- diff --git a/Makefile b/Makefile index 64f14aa..cc62984 100644 --- a/Makefile +++ b/Makefile @@ -321,7 +321,7 @@ KALLSYMS = scripts/kallsyms PERL = perl CHECK = sparse -CHECKFLAGS := -D__linux__ -Dlinux -D__STDC__ -Dunix -D__unix__ -Wbitwise $(CF) +CHECKFLAGS := -D__linux__ -Dlinux -D__STDC__ -Dunix -D__unix__ -Wbitwise -Wno-return-void $(CF) MODFLAGS = -DMODULE CFLAGS_MODULE = $(MODFLAGS) AFLAGS_MODULE = $(MODFLAGS) From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hannes Eder Date: Sat, 27 Dec 2008 19:11:11 +0000 Subject: Re: [PATCH 03/27] drivers/net: fix sparse warning: returning void-valued expression Message-Id: <49567dd3.0b38560a.3c6c.0511@mx.google.com> List-Id: References: <20081222191259.11807.53190.stgit@vmbox.hanneseder.net> <20081222191517.11807.20718.stgit@vmbox.hanneseder.net> <20081225.161740.10052019.davem@davemloft.net> <20081226115921.bb094c58.rdunlap@xenotime.net> In-Reply-To: <20081226115921.bb094c58.rdunlap@xenotime.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Randy Dunlap Cc: David Miller , netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org On 12/26/08, Randy Dunlap wrote: > On Thu, 25 Dec 2008 16:17:40 -0800 (PST) > > David Miller wrote: > > > > From: Hannes Eder > > Date: Mon, 22 Dec 2008 20:15:17 +0100 > > > > > Fix this sparse warning: > > > > > > drivers/net/niu.c:8850:2: warning: returning void-valued expression > > > > > > Signed-off-by: Hannes Eder > > > > Can we just fix sparse not to generate this warning? It's > > marginal, at best. C++ even explicitly defines this as valid > > and last time I brought this up Linus even agreed. > > > Ack, I discussed it with him also and he thought that > they were just fine as they were... > > > > The types match, the function returns void and it is returning a void, > > what is the problem? In fact there is no need to _fix_ sparse, as there is a command line option -Wreturn-void / -Wno-return-void, so we could change the Makefile, see diff below. --- diff --git a/Makefile b/Makefile index 64f14aa..cc62984 100644 --- a/Makefile +++ b/Makefile @@ -321,7 +321,7 @@ KALLSYMS = scripts/kallsyms PERL = perl CHECK = sparse -CHECKFLAGS := -D__linux__ -Dlinux -D__STDC__ -Dunix -D__unix__ -Wbitwise $(CF) +CHECKFLAGS := -D__linux__ -Dlinux -D__STDC__ -Dunix -D__unix__ -Wbitwise -Wno-return-void $(CF) MODFLAGS = -DMODULE CFLAGS_MODULE = $(MODFLAGS) AFLAGS_MODULE = $(MODFLAGS)