From mboxrd@z Thu Jan 1 00:00:00 1970 From: wking@tremily.us Subject: [PATCH v6 1/3] gitweb: add `status` headers to git_feed() responses. Date: Wed, 28 Mar 2012 11:46:59 -0400 Message-ID: <4958e06536924de10105bb453d88e8f4c28bb8c1.1332949186.git.wking@drexel.edu> References: <201203281613.52624.jnareb@gmail.com> Cc: Junio C Hamano , git@vger.kernel.org, "W. Trevor King" To: Jakub Narebski X-From: git-owner@vger.kernel.org Wed Mar 28 17:48:02 2012 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SCv6L-0003cK-AQ for gcvg-git-2@plane.gmane.org; Wed, 28 Mar 2012 17:47:57 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758067Ab2C1Prw (ORCPT ); Wed, 28 Mar 2012 11:47:52 -0400 Received: from vms173019pub.verizon.net ([206.46.173.19]:26862 "EHLO vms173019pub.verizon.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754734Ab2C1Prw (ORCPT ); Wed, 28 Mar 2012 11:47:52 -0400 Received: from odin.tremily.us ([unknown] [72.68.98.116]) by vms173019.mailsrvcs.net (Sun Java(tm) System Messaging Server 7u2-7.02 32bit (built Apr 16 2009)) with ESMTPA id <0M1L001RIQIZK300@vms173019.mailsrvcs.net> for git@vger.kernel.org; Wed, 28 Mar 2012 10:47:29 -0500 (CDT) Received: from mjolnir (mjolnir.tremily.us [192.168.0.6]) by odin.tremily.us (Postfix) with ESMTPS id 1D56343ADE6; Wed, 28 Mar 2012 11:47:22 -0400 (EDT) Received: by mjolnir (sSMTP sendmail emulation); Wed, 28 Mar 2012 11:47:38 -0400 X-Mailer: git-send-email 1.7.3.4 In-reply-to: <201203281613.52624.jnareb@gmail.com> In-reply-to: References: Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: The git_feed() method was not setting a `Status` header unless it was responding to an If-Modified-Since request with `304 Not Modified`. Now, when it is serving successful responses, it sets status to `200 OK`. Signed-off-by: W Trevor King --- gitweb/gitweb.perl | 6 ++++-- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl index a8b5fad..041da17 100755 --- a/gitweb/gitweb.perl +++ b/gitweb/gitweb.perl @@ -7841,11 +7841,13 @@ sub git_feed { print $cgi->header( -type => $content_type, -charset => 'utf-8', - -last_modified => $latest_date{'rfc2822'}); + -last_modified => $latest_date{'rfc2822'}, + -status => '200 OK'); } else { print $cgi->header( -type => $content_type, - -charset => 'utf-8'); + -charset => 'utf-8', + -status => '200 OK'); } # Optimization: skip generating the body if client asks only -- 1.7.3.4