From: "W. Trevor King" <wking@drexel.edu>
To: git@vger.kernel.org
Cc: Junio C Hamano <gitster@pobox.com>,
Jakub Narebski <jnareb@gmail.com>,
"W. Trevor King" <wking@drexel.edu>
Subject: [PATCH v7 1/3] gitweb: add `status` headers to git_feed() responses.
Date: Wed, 28 Mar 2012 13:44:16 -0400 [thread overview]
Message-ID: <4958e06536924de10105bb453d88e8f4c28bb8c1.1332956550.git.wking@drexel.edu> (raw)
In-Reply-To: <20120328164513.GA4389@odin.tremily.us>
In-Reply-To: <cover.1332956550.git.wking@drexel.edu>
The git_feed() method was not setting a `Status` header unless it was
responding to an If-Modified-Since request with `304 Not Modified`.
Now, when it is serving successful responses, it sets status to `200
OK`.
Signed-off-by: W Trevor King <wking@drexel.edu>
---
gitweb/gitweb.perl | 6 ++++--
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index a8b5fad..041da17 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -7841,11 +7841,13 @@ sub git_feed {
print $cgi->header(
-type => $content_type,
-charset => 'utf-8',
- -last_modified => $latest_date{'rfc2822'});
+ -last_modified => $latest_date{'rfc2822'},
+ -status => '200 OK');
} else {
print $cgi->header(
-type => $content_type,
- -charset => 'utf-8');
+ -charset => 'utf-8',
+ -status => '200 OK');
}
# Optimization: skip generating the body if client asks only
--
1.7.3.4
next prev parent reply other threads:[~2012-03-28 18:44 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20120328164513.GA4389@odin.tremily.us>
2012-03-28 17:44 ` [PATCH v7 0/3] gitweb: refactor If-Modified-Since handling W. Trevor King
2012-03-28 17:44 ` W. Trevor King [this message]
2012-03-28 17:44 ` [PATCH v7 2/3] " W. Trevor King
2012-03-28 17:44 ` [PATCH v7 3/3] gitweb: add If-Modified-Since handling to git_snapshot() W. Trevor King
2012-03-28 18:11 ` Jakub Narebski
2012-03-28 18:37 ` W. Trevor King
2012-03-28 19:11 ` Junio C Hamano
2012-03-28 19:27 ` W. Trevor King
2012-03-28 21:45 ` Jakub Narebski
2012-03-28 21:28 ` Jakub Narebski
2012-03-29 12:45 ` [PATCH v8 0/3] gitweb: refactor If-Modified-Since handling W. Trevor King
2012-03-29 12:45 ` [PATCH v8 1/3] gitweb: add `status` headers to git_feed() responses W. Trevor King
2012-03-30 15:21 ` Jakub Narebski
2012-03-29 12:45 ` [PATCH v8 2/3] gitweb: refactor If-Modified-Since handling W. Trevor King
2012-03-30 15:30 ` Jakub Narebski
2012-03-29 12:45 ` [PATCH v8 3/3] gitweb: add If-Modified-Since handling to git_snapshot() W. Trevor King
2012-03-30 16:07 ` Jakub Narebski
2012-03-30 16:11 ` [PATCH v8 0/3] gitweb: refactor If-Modified-Since handling Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4958e06536924de10105bb453d88e8f4c28bb8c1.1332956550.git.wking@drexel.edu \
--to=wking@drexel.edu \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jnareb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.