From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9060EC433F5 for ; Wed, 13 Apr 2022 03:01:22 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id E32A783D3D; Wed, 13 Apr 2022 05:01:19 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=oss.nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="BZcgJyIz"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 7A7D083E41; Wed, 13 Apr 2022 05:01:17 +0200 (CEST) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on20623.outbound.protection.outlook.com [IPv6:2a01:111:f400:7e1b::623]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id C371683D3D for ; Wed, 13 Apr 2022 05:01:14 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=oss.nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=peng.fan@oss.nxp.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kK7KAZoVxfAL//WN73u/KXBqmLLzNAO7l2xzqzWuBos9AY733XtUUdeFCT0KE5nrFiZSAJCIJId0774HFlzBrC6QFxk+H/Xz1PDW5rfO4XLAds0qo2s+kpUH9S2A7YXxF+MwHGJjiVTVIkz4x1Nfc+lEBTP5CfyxKUsqDhFyEjpbZ6GGvwJl5zFL/Dp79WmUeSTAHL1ZAvBCBZHK64c7E4cFRG8XcHaDtRSMXrhukdLxOdJVfsCppLJn686cmXrYWAyU63j7/f4YhrF65PTEdT4BKnIPq6UVBGaNzJU7FalTXwzy6ILCyFFlJ5EOsDUVRIYmbKRxstAzS+jLK4woiw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kPuvcVG+x5Sxm8ZHlIM1ZhCtWHcye89fpmUXWFYBLIE=; b=Wk4Fm22nOfewAgjJDiIES6TyDdc5WQOuZCVSQtUCE+6H3ui+TcDdFUmJ1vR9uO3xJ0ykcQSSFj/k9o0peLvmrUPi2APxemW2vRTNRVBqLghDHG9dSluWetYHUGZBvG0SewM1Shd3rN6yIgxY8bbS9MUWbaph2NkegJp4Dmjaqawg23gYVvu+kyGBPw2ak/So3bZJ7C9Vs322gpFYN1tty/TBOJdNC4w9Hzbjs+PXfL0FJ48zABkh2AUriiSQ4fg7/0+Bz1rhIFC6uvTaXboVA+U7ifq9VNLCvRnuDambl3onAYx0x/Nfk9JRP/D75zwqofWCrOw3lXMQYyOjn49s2g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kPuvcVG+x5Sxm8ZHlIM1ZhCtWHcye89fpmUXWFYBLIE=; b=BZcgJyIzXHMfpUW4qkCL/LHAednEEjnbbKZu/qzLRNjMz4tp++XM4cZcQmEk9zJP79IB2icg0oSr2jYxRLYD3QKmFV5JNdJkNdoXC25ylZfFaLZz8aKmASEVSiz2haRkAr79+S5atXEd3Qi1u5gGlq/riCGQRo83vUFaxn/rS4k= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) by VE1PR04MB6703.eurprd04.prod.outlook.com (2603:10a6:803:129::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.30; Wed, 13 Apr 2022 03:01:12 +0000 Received: from DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::389f:e6eb:a7a2:61b6]) by DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::389f:e6eb:a7a2:61b6%8]) with mapi id 15.20.5144.029; Wed, 13 Apr 2022 03:01:12 +0000 Subject: Re: [PATCH V2 19/26] imx: imx8ulp_evk: Power down the domains may used in u-boot To: Stefano Babic Cc: "festevam@gmail.com" , "u-boot@lists.denx.de" , dl-uboot-imx , Ye Li References: <20220406063031.21960-1-peng.fan@oss.nxp.com> <20220406063031.21960-20-peng.fan@oss.nxp.com> From: "Peng Fan (OSS)" Message-ID: <4963df3b-ba38-5d33-ab57-ecb5344971a6@oss.nxp.com> Date: Wed, 13 Apr 2022 11:00:59 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SI2PR04CA0002.apcprd04.prod.outlook.com (2603:1096:4:197::17) To DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: bfcfac73-2483-417c-e074-08da1cf9ddd1 X-MS-TrafficTypeDiagnostic: VE1PR04MB6703:EE_ X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /VaOdKUMKtZ96ikz0ChbSgiqxNo70O69Qc3zxgnPv2e5IlDuwi3Bst4A+JzDJ4JhLVLSo4bb+4WdWCfGNRHkl21JWSKYvUUFkFFF0SZ29Ws05iB3+ybfO8AoNh5dNJU1+Dx6Vtz2bSPIkQi6/GwuqcKHmF5vRwFTcEoFh2Y4lEi1pYfIRGB65oyM9jbfgoFq5pkLabP8AdWMK38ohzVahzUw4Eb/7tVXfUj6ygSSL+plvFoVNFAHSaPdNEBWKVqbfOJ77XHdk4fsVIg/0zJ9G2wG+Ui210kQ/9X6nWQULtOq+nPeR3r0pAiMeSC59VESqTi5Uz9tYBCtYnKTzSs0ISLfjdjVvIc6kLgNgJRYf4uQFzrAbQwovnwUOoy0cwLGCvSIJo7ANdmwE2BNqeGhqMuNuNiZO5/7BO1LhGKZGPJSEiH6BrChqlLSVGBtAK+7sLhZrezyGHsEWvRD2cOAUr9qXhfRr8jZaTsUXXUMTbQ4NkfRz27+jXAfE3uUZhAKFV5/a6Gy/vz3KGn9YgnSCedT5k5VJ9EIkAUreH5ennRGHIW8tmQ08JLd5GCf4wzCdZj58d3YJDzV5J6ovi9+9kZpipaZTp212jXBtIZFgwBlEMWbpKAkYJ5eO8X7e+7Soj5oGHebQYRYGneE+gkiU/QtN/oBZKhYiZZCEPbY/jgjWW/MGfIRSykLoV9EwijX4QDTM4j6TzTYPNd5L6uto0HUxCb0nYlVR8692M+mJ7dmUQT6XLjAPJOtiH80Qgzrbmsq2O0LGZgHmuyYyOyj5g== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DU0PR04MB9417.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(8936002)(2616005)(5660300002)(6666004)(6486002)(316002)(66946007)(31696002)(66476007)(6512007)(66556008)(8676002)(4326008)(86362001)(508600001)(38350700002)(6916009)(54906003)(38100700002)(53546011)(52116002)(6506007)(186003)(31686004)(2906002)(26005)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Y0tmbmFlSUE3WndNalR0S1A1MUtCa3dIZWN2NzhKT25XeEZmNWVCYUk5dThK?= =?utf-8?B?OEFGM1Q3MWdab05PZWx6bkxUUlVwTmNvN3NDaVRPeklqSFgwS0FLYXBDc1h1?= =?utf-8?B?bG1MR2RzV2RwVkJ3a0ZlKytNWXlsRGQxWTZTNDlQcVZlN0UyWHNGK1ZaRDFv?= =?utf-8?B?S3dPUk1zenp2TlpSODhlOWlTcmtFbUVmT0FyVm04QmdtZEFTcjVWNXZVYS81?= =?utf-8?B?b2d6bDdjT3pmbXVBZUhLcmhTM3BpV3pPbFhuWkR5dmVXSUw0ak5ycDZuZDgx?= =?utf-8?B?MDdNZ0pNWk5pODdrOGhtaXFBU1ZKT0FsVjN4clBxbjVrREF4SC9ZcWRQd21D?= =?utf-8?B?TTlhYmE5dnZWeDdKSjJtZHZtNUtjbUJRTGxCUUg4RHM0Y1Q2eG1yVUMzT3dp?= =?utf-8?B?akh0a0Zjd1U5UDJIUjJJQmhYc01jYVlFVnZHaHl3TmNGZFlDNHBVeWNEOGtV?= =?utf-8?B?blJOZ0RCc0U0WjlQQUVsS3JPNFlzcXRsOFl5cTdyckZwNE91OGFqUGtoOWZ4?= =?utf-8?B?M2dDWXlwb2ZhWkZSNHVGMHRBWmtaNXZyaS95b3ZyYUplSkk1SnlxcWp0NXNr?= =?utf-8?B?Rk10Q3F3YWxKVHp0aHEzSkJzMWRiQ3VVdVkwRnlwMmxjZ2w1clllaG9HbUJm?= =?utf-8?B?N1Qva243MDhjVUVLVytrWWFXYm12NjN6a0tWcDRiOGFrMjFLSDR6UXNVaS9C?= =?utf-8?B?Zkt0STYvUmU2Z1VhN1JEMnhXYXVOd0t3RzJvSUQ5WDR4WlZ0OHBLS3piVkw1?= =?utf-8?B?ZGxsYzBUQS9teDF1RmFGdC9rZTdIWVYrcmRVd2hpSUoxMGtLQVYyQzZRNVho?= =?utf-8?B?VE9Oa1JnQm9CVnFBdEZVVW9aekNKMTVvbmd0eFZ2VVFpT3pKbWdhSS9SMERq?= =?utf-8?B?VWF4K1h2NXZQbEkyTUZFbTFqKzZVTzFvT3dWa24zNjIvRElXOWVMSzFjV0ZZ?= =?utf-8?B?YkRPUWlDWkpiK3pUUTAvYmVDVXlCSGgvaUwveWtvRkZrdDRyellpa2VsclN4?= =?utf-8?B?bEQwWXZPUWVrNnI1Mm9DcTdOZzVydWVvWVJDNHVXcW1KWk9UQ2RvcFZyWjZz?= =?utf-8?B?WmQyR0lkT1VjREpiSUNnYVFQcG9JbHEwVURBQUhFeHg5djlCY3d6dHJ6Y1FG?= =?utf-8?B?SmxaVVZFK1F3Q1dYUFdhU3hrb0dKbEVWNE1BcStISWhlN25ud2RHWHN1cVQ4?= =?utf-8?B?NURraDhMZWhXY1dJWGZidWRWRXYveHNMLzJwUHVwZUhLWWhvUWE0b3VEOE01?= =?utf-8?B?NktJRkNpRE5iNXUxVjRmTHdSMmFGdDFSZENtd2dKNE5DMmoyaG5qdG14a1E3?= =?utf-8?B?eTFhbGVjUVZyb25YdlZERUdaZEdDMWdlT3lnTktXaDF6TjBUMjZMOXphSWtI?= =?utf-8?B?ejBLRGhmbnExTWMweW1OLytkeW5pNUpNUlZ3ZTQrS2pUeTVqVHpRTDhzWFlQ?= =?utf-8?B?KzRUMEpqTGU1WHdjdGJyNVNQc1NBdXRDNGJBbFRKRWpuOVdGUUxZVUQ4UXpB?= =?utf-8?B?NDdFaDY3LzVHTTY1NlA3cnZZaWhqUHhxc253K0pocy9tTDMyRHlyUVYxaVRj?= =?utf-8?B?NTRiOVJNRm5RaGQ1QlF0aDRFQlNWakVydmp1MHROWWJGMzZ4bG9NSS9qYWRv?= =?utf-8?B?NmhWTzBuODFIN0JhcEdlTU5CbzRCMGZ1V1dIZEp4Ky90M3BLVEFtNjd1dmxO?= =?utf-8?B?cjJ3aWFJRm5SdllPeUFrbFZOR2t0YXRJdEZ4N2lHcUp5SjhneEZtKzQrN2pu?= =?utf-8?B?UVVqa1l5RVd6am9qd3dzNjdTSHJXQjZ0V0dtN2NjZlpUTFN6T2dkL0VNVWl5?= =?utf-8?B?UGdGRWZORkx3VzVoVzhNUS9USmdLUWw4cGwrQXVJSmx2VHFXVzZlY2dUMWJE?= =?utf-8?B?UnJpMDlxakdDM2xMYlFDZ2tuUkdCSytKMWpMVExmZVU0d0pOOHNtNWN6RU9T?= =?utf-8?B?TFR3clNvOXVESVBMSXc5WDdTL3FINGlVelZYSUMxR2NqalpMTWlma0kvaE03?= =?utf-8?B?cVlINVQ3ZEcwRktqdUpucFJiQjFiWS9STEZzVS9pOVdDWjJYMGVaNFd4UE1U?= =?utf-8?B?Ykp2UEh3ZWJ0T1lOVUhYTzZITXV0UDFla0s0eUIydjZxQzdVTFVKRnZWNmRK?= =?utf-8?B?NkN0SjJacDdwcjFOTE92aXA0TEhhZjVaTGJBcDNUaXoxZ2tkT296dC9WV0Rs?= =?utf-8?B?RzRadGVxWmYyZUhpWmFvaVJjTC80UkhUR1ArK3hQcm51ekNJYVk1WDhEczFh?= =?utf-8?B?aUxJRTdrclc1a1djMWxmOVZwUVdML3VZc241aG1WZW9BL05VVWZVY29SQVVP?= =?utf-8?B?cU5LNFJxZFpSQ2g2ZXRpc2habFd1QXlYWk9yMHhiOURIWHlzeHlNdz09?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: bfcfac73-2483-417c-e074-08da1cf9ddd1 X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Apr 2022 03:01:12.3737 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: fSN+FNojEG+5CZuuMZ6pS+IAS0opw0QoMa9b3h+25Qmk+seFMCqSd/kKQ5wXjG5PWBZT5mnvPz16hQtaOTCmZQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6703 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean Hi Stefano, On 2022/4/13 1:10, Stefano Babic wrote: > Hi Peng,Ye, > > On 06.04.22 08:30, Peng Fan (OSS) wrote: >> From: Ye Li >> >> Since ATF power domain will hold the enable counter for each power domain, >> We need to power off them before entering kernel to avoid this >> power domain can't be really powered off. >> >> Signed-off-by: Ye Li >> Signed-off-by: Peng Fan >> --- >> board/freescale/imx8ulp_evk/imx8ulp_evk.c | 30 +++++++++++++++++++++++ >> 1 file changed, 30 insertions(+) >> >> diff --git a/board/freescale/imx8ulp_evk/imx8ulp_evk.c b/board/freescale/imx8ulp_evk/imx8ulp_evk.c >> index b61a4cfbe8d..1bd308148f3 100644 >> --- a/board/freescale/imx8ulp_evk/imx8ulp_evk.c >> +++ b/board/freescale/imx8ulp_evk/imx8ulp_evk.c >> @@ -13,6 +13,8 @@ >> #include >> #include >> #include >> +#include >> +#include > > But which patch is adding the file above ? I cannot find it, it is not > part of this series and of course build is broken without it. V5 patchset should not have such issue. I just see you already picked up V5 in your repo. Thanks, Peng. > > Best regards, > Stefano > >> DECLARE_GLOBAL_DATA_PTR; >> >> @@ -129,3 +131,31 @@ int board_late_init(void) >> { >> return 0; >> } >> + >> +void board_quiesce_devices(void) >> +{ >> + /* Disable the power domains may used in u-boot before entering kernel */ >> +#if CONFIG_IS_ENABLED(POWER_DOMAIN) >> + struct udevice *scmi_devpd; >> + int ret, i; >> + struct power_domain pd; >> + ulong ids[] = { IMX8ULP_PD_FLEXSPI2, IMX8ULP_PD_USB0, IMX8ULP_PD_USDHC0, >> + IMX8ULP_PD_USDHC1, IMX8ULP_PD_USDHC2_USB1, IMX8ULP_PD_DCNANO, >> + IMX8ULP_PD_MIPI_DSI }; >> + >> + ret = uclass_get_device(UCLASS_POWER_DOMAIN, 0, &scmi_devpd); >> + if (ret) { >> + printf("Cannot get scmi devpd: err=%d\n", ret); >> + return; >> + } >> + >> + pd.dev = scmi_devpd; >> + >> + for (i = 0; i < ARRAY_SIZE(ids); i++) { >> + pd.id = ids[i]; >> + ret = power_domain_off(&pd); >> + if (ret) >> + printf("power_domain_off %lu failed: err=%d\n", ids[i], ret); >> + } >> +#endif >> +} >