At 2022-07-14 15:37:41, "Laurentiu Palcu" <laurentiu.palcu@oss.nxp.com> wrote:
>Hi Liang,
>
>Thanks for the patch.
>
>The patch is ok but, since you're at it, maybe add of_node_put() in the
>dcss_dev_destroy() too?
>
Thanks, laurentiu,
I miss it and I will add it soon.

>Thanks,
>laurentiu
>
>On Thu, Jul 07, 2022 at 10:32:14AM +0800, Liang He wrote:
>> In dcss_dev_create(), we should call of_node_put() in fail path for
>> of_graph_get_port_by_id() which will increase the refcount.
>> 
>> Fixes: 9021c317b770 ("drm/imx: Add initial support for DCSS on iMX8MQ")
>> Signed-off-by: Liang He <windhl@126.com>
>> ---
>>  drivers/gpu/drm/imx/dcss/dcss-dev.c | 1 +
>>  1 file changed, 1 insertion(+)
>> 
>> diff --git a/drivers/gpu/drm/imx/dcss/dcss-dev.c b/drivers/gpu/drm/imx/dcss/dcss-dev.c
>> index c849533ca83e..a99141538621 100644
>> --- a/drivers/gpu/drm/imx/dcss/dcss-dev.c
>> +++ b/drivers/gpu/drm/imx/dcss/dcss-dev.c
>> @@ -207,6 +207,7 @@ struct dcss_dev *dcss_dev_create(struct device *dev, bool hdmi_output)
>>  
>>  	ret = dcss_submodules_init(dcss);
>>  	if (ret) {
>> +		of_node_put(dcss->of_port);
>>  		dev_err(dev, "submodules initialization failed\n");
>>  		goto clks_err;
>>  	}
>> -- 
>> 2.25.1
>>