All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dor Laor <dlaor@redhat.com>
To: qemu-devel@nongnu.org
Cc: Mark McLoughlin <markmc@redhat.com>, kvm <kvm@vger.kernel.org>
Subject: Re: [Qemu-devel] Re: [PATCH 1/5] virtio-net: Allow setting the MAC address via set_config
Date: Thu, 15 Jan 2009 00:08:52 +0200	[thread overview]
Message-ID: <496E6274.6050707@redhat.com> (raw)
In-Reply-To: <20090114164155.GA6431@shareable.org>

Jamie Lokier wrote:
> Alex Williamson wrote:
>   
>>> What if the guest will chose the host's mac?
>>> Thinking about it, I don't think we should test that.
>>> A concerned host mgmt app can add ebtables roles for such a case.
>>>
>>> Maybe we can optionally allow/deny it?
>>>       
>> What's the topology you're thinking of that the virtio-net MAC is also
>> the host MAC?  I typically use a bridge with a tap device, so the
>> virtio-net MAC is isolated from the host.  Thanks,
>>     
>
> For example you might forward IPX packets to the guest and IP/ARP to
> the host, using an ebtables rule to distinguish them.  From the
> outside, it would look equivalent to a single host processing both IPX
> and IP.
>
> -- Jamie
>
>   
That's a nice common scenario ;)
What I meant is that if we allow the guest to change his mac address, it 
can deliberately
change it to other hosts/guests mac and thus create networking problems.
Although guest can always mangle packets, maybe it worth enforcing these 
macs for the guest.

Thanks,
Dor

      parent reply	other threads:[~2009-01-14 22:08 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-13 21:23 [PATCH 1/5] virtio-net: Allow setting the MAC address via set_config Alex Williamson
2009-01-13 21:23 ` [Qemu-devel] " Alex Williamson
2009-01-14 10:05 ` Dor Laor
2009-01-14 10:05   ` [Qemu-devel] " Dor Laor
2009-01-14 15:34   ` Alex Williamson
2009-01-14 15:34     ` [Qemu-devel] " Alex Williamson
2009-01-14 16:41     ` Jamie Lokier
2009-01-14 16:41       ` Jamie Lokier
2009-01-14 22:06       ` Dor Laor
2009-01-14 22:14         ` Paul Brook
2009-01-15 13:11           ` Jamie Lokier
2009-01-15 13:11             ` Jamie Lokier
2009-01-15 13:12         ` Jamie Lokier
2009-01-15 13:41           ` Avi Kivity
2009-01-15 13:41             ` Avi Kivity
2009-01-18  9:37           ` Dor Laor
2009-01-18  9:42             ` Avi Kivity
2009-01-14 22:08       ` Dor Laor [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=496E6274.6050707@redhat.com \
    --to=dlaor@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=markmc@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.