From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D02BEC433DF for ; Sun, 5 Jul 2020 07:40:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 44E7B206BE for ; Sun, 5 Jul 2020 07:40:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=goldelico.com header.i=@goldelico.com header.b="EDsjl1NK" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725967AbgGEHkw (ORCPT ); Sun, 5 Jul 2020 03:40:52 -0400 Received: from mo4-p01-ob.smtp.rzone.de ([85.215.255.53]:10558 "EHLO mo4-p01-ob.smtp.rzone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725901AbgGEHkw (ORCPT ); Sun, 5 Jul 2020 03:40:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1593934847; s=strato-dkim-0002; d=goldelico.com; h=To:References:Message-Id:Cc:Date:In-Reply-To:From:Subject: X-RZG-CLASS-ID:X-RZG-AUTH:From:Subject:Sender; bh=nrpO7LlX05/QUSJ/KE9R/uWunrjDcgnFW5PQQlRom7o=; b=EDsjl1NKT9tRf7uigau3wDBRSlpcU9SnZ9YYKIf0koRLUHpQ4JOfiX7zpEic1RKCGE FXzjuHfnoUMueWpiRv4ukE2iMGykaxubpwvQ1oRHFFLntzz8KurLChyN1UslKEFDQsnd ZXa2J33Zo6+1urRa42Yc0M3F7Ot4zj0YQwtsWYOGb+S8888Ut2vmx0M5SBj9RUXrSF7H YiW3H0/Fr9EjdbQd5QvqaEUv6KsuYohLqem57u6rVb/r5O3orhUtzrUGYRNxCQ13aUEh 4CyhLcjDiacAk4ZoLW2GSum1CXfUUHFKyHIajlP+R3cnvNlcGgVu9MZP4WZQAr68rpmn t+rw== X-RZG-AUTH: ":JGIXVUS7cutRB/49FwqZ7WcJeFKiMgPgp8VKxflSZ1P34KBj7wpz8NMGHPrqwDCpBMA=" X-RZG-CLASS-ID: mo00 Received: from imac.fritz.box by smtp.strato.de (RZmta 46.10.5 DYNA|AUTH) with ESMTPSA id V07054w657ealvi (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (curve X9_62_prime256v1 with 256 ECDH bits, eq. 3072 bits RSA)) (Client did not present a certificate); Sun, 5 Jul 2020 09:40:36 +0200 (CEST) Subject: Re: OMAP5: inconsistency between target-module and dsi_of_data_omap5 Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Content-Type: text/plain; charset=us-ascii From: "H. Nikolaus Schaller" In-Reply-To: Date: Sun, 5 Jul 2020 09:40:36 +0200 Cc: Discussions about the Letux Kernel , kernel@pyra-handheld.com, Linux-OMAP , Tomi Valkeinen , Laurent Pinchart , Jyri Sarha Content-Transfer-Encoding: quoted-printable Message-Id: <49725F81-E615-4101-81B3-0850F201D9E8@goldelico.com> References: To: Tony Lindgren X-Mailer: Apple Mail (2.3124) Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org > Am 05.07.2020 um 08:52 schrieb H. Nikolaus Schaller = : >=20 > Hi Tony, > since v5.7-rc1 our Pyra (OMAP5) dsi panel doesn't initialize and we do = not > get a /dev/fb0. >=20 > There is a suspicious log message: >=20 > [ 15.352314] DSI: omapdss DSI error: unsupported DSI module >=20 > I could trace it down to be likely a discrepancy between >=20 > target-module@58000000 {=20 >=20 > ... >=20 > target-module@5000 { > compatible =3D "ti,sysc-omap2", = "ti,sysc"; > reg =3D <0x5000 0x4>, > ... > ranges =3D <0 0x5000 0x1000>; >=20 > dsi1: encoder@0 { > compatible =3D = "ti,omap5-dsi"; >=20 > target-module@9000 { > compatible =3D "ti,sysc-omap2", = "ti,sysc"; > reg =3D <0x9000 0x4>, > <0x9010 0x4>, > <0x9014 0x4>; >=20 > ... >=20 > ranges =3D <0 0x9000 0x1000>; >=20 > dsi2: encoder@0 { > compatible =3D = "ti,omap5-dsi"; > reg =3D <0 0x200>, > <0x200 0x40>, > <0x300 0x40>; >=20 >=20 >=20 > and >=20 > static const struct dsi_of_data dsi_of_data_omap5 =3D { > .model =3D DSI_MODEL_OMAP5, > .pll_hw =3D &dss_omap5_dsi_pll_hw, > .modules =3D (const struct dsi_module_id_data[]) { > { .address =3D 0x58004000, .id =3D 0, }, > { .address =3D 0x58009000, .id =3D 1, }, > { }, > }, >=20 > Therefore the address match logic in dsi_probe() fails and ends in > the mentioned log message. >=20 > Looking at git blame, the DTS was recently changed by 5a507162f096b54. > Commit 98e1a6a86a22d62 did do a similar change for dsi2 but did not > modify the address. >=20 > So I wonder if the 0x5000 is just a typo or if there is something > where the dsi1: encoder@0 should have a negative offset to end > up at address 0x58004000? >=20 > BR and thanks, > Nikolaus >=20 This patch makes the DSI error go away and omapdrm initialized: diff --git a/arch/arm/boot/dts/omap5.dtsi b/arch/arm/boot/dts/omap5.dtsi index e147121513e644..b9f54f62163879 100644 --- a/arch/arm/boot/dts/omap5.dtsi +++ b/arch/arm/boot/dts/omap5.dtsi @@ -474,7 +474,7 @@ rfbi: encoder@0 { }; }; =20 - target-module@5000 { + target-module@4000 { compatible =3D "ti,sysc-omap2", = "ti,sysc"; reg =3D <0x5000 0x4>, <0x5010 0x4>, @@ -490,7 +490,7 @@ SYSC_OMAP2_SOFTRESET | ti,syss-mask =3D <1>; #address-cells =3D <1>; #size-cells =3D <1>; - ranges =3D <0 0x5000 0x1000>; + ranges =3D <0 0x4000 0x1000>; =20 dsi1: encoder@0 { compatible =3D = "ti,omap5-dsi"; But I still have no display: [ 17.537515] [drm] Initialized omapdrm 1.0.0 20110917 for omapdrm.0 on = minor 2 [ 18.558950] omapdrm omapdrm.0: [drm] Cannot find any crtc or sizes So there is more to fix. BR, Nikolaus