From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Dai, Wei" Subject: Re: [PATCH v3 4/4] eal: fix end character check in --lcores argument Date: Tue, 2 Aug 2016 08:22:29 +0000 Message-ID: <49759EB36A64CF4892C1AFEC9231E8D63A268522@PGSMSX106.gar.corp.intel.com> References: <1469081018-55300-1-git-send-email-wei.dai@intel.com> <1469618870-144592-1-git-send-email-wei.dai@intel.com> <579A2433.1060701@intel.com> <1717702.2SVR8RdYDI@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: "dev@dpdk.org" , "Yigit, Ferruh" , "adambynes@outlook.com" , "Liang, Cunming" To: Thomas Monjalon Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 27FB15962 for ; Tue, 2 Aug 2016 10:25:21 +0200 (CEST) In-Reply-To: <1717702.2SVR8RdYDI@xps13> Content-Language: en-US List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, Thomas, Yigit > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Friday, July 29, 2016 12:06 AM > To: Dai, Wei > Cc: dev@dpdk.org; Yigit, Ferruh > Subject: Re: [dpdk-dev] [PATCH v3 4/4] eal: fix end character check in --= lcores > argument >=20 > 2016-07-28 16:26, Ferruh Yigit: > > On 7/27/2016 12:27 PM, Wei Dai wrote: > > > With --lcores 'a-b@c-d', eal_parse_cores() fails because > > > eal_parse_set() fails due to the next character after lcore set a-b, > > > which is '@'and not ',' or '\0'. > > > There is also a right check immediately after this incorrect check. > > > > > > Fixes: 53e54bf81700 ("eal: new option --lcores for cpu assignment") > > > > > > Signed-off-by: Wei Dai > > > > I am not sure if a-b@c-d syntax should be supported. (a-b)@(c-d) is > > supported and already working. >=20 > Agreed. >=20 > Series applied, except this last patch 4, thanks Sorry, I can't find any document to clarify whether a-b@c-d shoule be suppo= rted. So I design following case to verify all kinds of combination of - and @.=20 I tested my patch with --lcores '0-3@12-15, 4-7@(8-11), (8-11)@4-7, (12-15= )@(0-3), 16-19, (20-23) ', After calling eal_parse_args(argc, argv), I observed lcore_config[i].cpuse= t to check cpuset of each lcore. I added following codes immediately after calling fctret =3D eal_parse_args= (argc, argv); in function rte_eal_init( ) in eal.c to check this patch. { struct rte_config *p; const char *rte_role_str[2] =3D {"ROLE_RTE", "ROLE_OFF"}; p =3D rte_eal_get_configuration(); for (i=3D0; i<28; i++) { printf("lcore %2d status =3D %s, runs on cpuset =3D 0x%08lX\n",=20 i, rte_role_str[p->lcore_role[i]], lcore_config[i].cpuset.__bits[0]); } } The result is as follow: lcore 0 status =3D ROLE_RTE, runs on cpuset =3D 0x0000F000 lcore 1 status =3D ROLE_RTE, runs on cpuset =3D 0x0000F000 lcore 2 status =3D ROLE_RTE, runs on cpuset =3D 0x0000F000 lcore 3 status =3D ROLE_RTE, runs on cpuset =3D 0x0000F000 lcore 4 status =3D ROLE_RTE, runs on cpuset =3D 0x00000F00 lcore 5 status =3D ROLE_RTE, runs on cpuset =3D 0x00000F00 lcore 6 status =3D ROLE_RTE, runs on cpuset =3D 0x00000F00 lcore 7 status =3D ROLE_RTE, runs on cpuset =3D 0x00000F00 lcore 8 status =3D ROLE_RTE, runs on cpuset =3D 0x000000F0 lcore 9 status =3D ROLE_RTE, runs on cpuset =3D 0x000000F0 lcore 10 status =3D ROLE_RTE, runs on cpuset =3D 0x000000F0 lcore 11 status =3D ROLE_RTE, runs on cpuset =3D 0x000000F0 lcore 12 status =3D ROLE_RTE, runs on cpuset =3D 0x0000000F lcore 13 status =3D ROLE_RTE, runs on cpuset =3D 0x0000000F lcore 14 status =3D ROLE_RTE, runs on cpuset =3D 0x0000000F lcore 15 status =3D ROLE_RTE, runs on cpuset =3D 0x0000000F lcore 16 status =3D ROLE_RTE, runs on cpuset =3D 0x00010000 lcore 17 status =3D ROLE_RTE, runs on cpuset =3D 0x00020000 lcore 18 status =3D ROLE_RTE, runs on cpuset =3D 0x00040000 lcore 19 status =3D ROLE_RTE, runs on cpuset =3D 0x00080000 lcore 20 status =3D ROLE_RTE, runs on cpuset =3D 0x00F00000 lcore 21 status =3D ROLE_RTE, runs on cpuset =3D 0x00F00000 lcore 22 status =3D ROLE_RTE, runs on cpuset =3D 0x00F00000 lcore 23 status =3D ROLE_RTE, runs on cpuset =3D 0x00F00000 lcore 24 status =3D ROLE_OFF, runs on cpuset =3D 0x00000000 lcore 25 status =3D ROLE_OFF, runs on cpuset =3D 0x00000000 lcore 26 status =3D ROLE_OFF, runs on cpuset =3D 0x00000000 lcore 27 status =3D ROLE_OFF, runs on cpuset =3D 0x00000000 =09