From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Dai, Wei" <wei.dai@intel.com>
Subject: Re: [PATCH] examples/ip_fragmentation: fix check of
	packet type
Date: Tue, 14 Mar 2017 01:18:34 +0000
Message-ID: <49759EB36A64CF4892C1AFEC9231E8D64E508753@PGSMSX101.gar.corp.intel.com>
References: <1489116490-2490-1-git-send-email-wei.dai@intel.com>
 <2601191342CEEE43887BDE71AB9772583FACD1BD@IRSMSX109.ger.corp.intel.com>
 <49759EB36A64CF4892C1AFEC9231E8D63A377512@PGSMSX106.gar.corp.intel.com>
 <2601191342CEEE43887BDE71AB9772583FACE36C@IRSMSX109.ger.corp.intel.com>
 <49759EB36A64CF4892C1AFEC9231E8D63A377662@PGSMSX106.gar.corp.intel.com>
 <2601191342CEEE43887BDE71AB9772583FACE96D@IRSMSX109.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "stable@dpdk.org" <stable@dpdk.org>
To: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>, "dev@dpdk.org"
 <dev@dpdk.org>
Return-path: <dev-bounces@dpdk.org>
In-Reply-To: <2601191342CEEE43887BDE71AB9772583FACE96D@IRSMSX109.ger.corp.intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

> -----Original Message-----
> From: Ananyev, Konstantin
> Sent: Tuesday, March 14, 2017 6:13 AM
> To: Dai, Wei <wei.dai@intel.com>; dev@dpdk.org
> Cc: stable@dpdk.org
> Subject: RE: [PATCH] examples/ip_fragmentation: fix check of packet type
>=20
>=20
>=20
> > > Hi Wei,
> > >
> > > >
> > > > Hi, Konstantin
> > > > I see your point.
> > > > I think your method can work.
> > > > But I think your method is a bit complex. As you method need to
> > > > add more
> > > codes.
> > > > Anyway this is a simple bug.
> > > > How do you think now ?
> > >
> > > I still think it is better for all apps to handle this issue in a uni=
form way.
> > > Again in that case for NICs that do support PTYPE offloads the
> > > performance should be unaffected.
> > > Konstantin
> > >
> >
> > I have just had a quick look through the l3fwd and didn't find any
> > codes to check what ptypes capabilities ae provided by stuff below DPDK
> PMD & its base driver.
> > L3fwd only check an input argument "--parse-ptype" to enable ptype
> > check implemented in a Rx callback function.
>=20
> As an example for lpm:
> http://dpdk.org/browse/dpdk/tree/examples/l3fwd/l3fwd_lpm.c#n279
> Konstantin

Thanks for your guide.
I will use rte_eth_dev_get_supported_ptypes( ) in my v2 patch.

>=20
>=20
> > In this l3fwd rx callback function,  it has done the same thing as my c=
ode.
> > Anyway, I'd like to provide a v2 patch to deal with this issue in a uni=
form way.
> >
> > Thanks & Best Regards
> > -Wei