From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Dai, Wei" <wei.dai@intel.com>
Subject: Re: [PATCH v2 5/5] app/testpmd: add command to test NIC
	restoration
Date: Thu, 29 Jun 2017 06:58:47 +0000
Message-ID: <49759EB36A64CF4892C1AFEC9231E8D650B4A826@KMSMSX153.gar.corp.intel.com>
References: <1495873329-43303-1-git-send-email-wei.dai@intel.com>
 <1498572438-25125-1-git-send-email-wei.dai@intel.com>
 <1498572438-25125-6-git-send-email-wei.dai@intel.com>
 <9BB6961774997848B5B42BEC655768F810DB349D@SHSMSX103.ccr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "dev@dpdk.org" <dev@dpdk.org>
To: "Wu, Jingjing" <jingjing.wu@intel.com>, "thomas@monjalon.net"
 <thomas@monjalon.net>, "Lu, Wenzhuo" <wenzhuo.lu@intel.com>, "Ananyev,
 Konstantin" <konstantin.ananyev@intel.com>, "Zhang, Helin"
 <helin.zhang@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
 by dpdk.org (Postfix) with ESMTP id CE7CD2B96
 for <dev@dpdk.org>; Thu, 29 Jun 2017 08:59:14 +0200 (CEST)
In-Reply-To: <9BB6961774997848B5B42BEC655768F810DB349D@SHSMSX103.ccr.corp.intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Thanks for your feedback.
V3 patch set will follow your guide.

> -----Original Message-----
> From: Wu, Jingjing
> Sent: Wednesday, June 28, 2017 5:05 PM
> To: Dai, Wei <wei.dai@intel.com>; thomas@monjalon.net; Lu, Wenzhuo
> <wenzhuo.lu@intel.com>; Ananyev, Konstantin
> <konstantin.ananyev@intel.com>; Zhang, Helin <helin.zhang@intel.com>
> Cc: dev@dpdk.org
> Subject: RE: [PATCH v2 5/5] app/testpmd: add command to test NIC restorat=
ion
>=20
>=20
>=20
> > -----Original Message-----
> > From: Dai, Wei
> > Sent: Tuesday, June 27, 2017 10:07 PM
> > To: thomas@monjalon.net; Lu, Wenzhuo <wenzhuo.lu@intel.com>; Ananyev,
> > Konstantin <konstantin.ananyev@intel.com>; Zhang, Helin
> > <helin.zhang@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>
> > Cc: dev@dpdk.org; Dai, Wei <wei.dai@intel.com>
> > Subject: [PATCH v2 5/5] app/testpmd: add command to test NIC
> > restoration
> >
> > When a NIC is reset, a message will show it.
> > And then user can run the command "reset_port port_id"
> > to reset the port and to keep same port id without any without any
> > configuration.
> > This patch adds a testpmd command "reconfig_port port_id"
> > to test whether the port can be reconfigured to have success Rx and Tx
> function.
> > The new command will configure the port with the simplest setting
> > which includes only 1 Rx queue, only 1 Tx queue, Rx mode =3D None and T=
x
> > mode =3D None.
> > It check if the port can receive and forward some packets.
> > For example 100 packets in this new command.
> > Before testing with "reset_port port_id" and then "reconfig_port
> > port_id", current forwarding should be stopped first to avoid crash.
> >
>=20
> Testpmd has mechanism to support reconfigure, you can check the
> need_reconfig Field in port struct.
> No need to define a new command.
>=20
>=20
> Thanks
> Jingjing