From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Dai, Wei" Subject: Re: [PATCH v3 1/6] net/ixgbevf: unregister irq handler when other interrupts not allowed. Date: Mon, 15 Jan 2018 04:57:53 +0000 Message-ID: <49759EB36A64CF4892C1AFEC9231E8D66CF2242D@PGSMSX112.gar.corp.intel.com> References: <1515924222-19044-1-git-send-email-xiangxia.m.yue@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: "dev@dpdk.org" To: "xiangxia.m.yue@gmail.com" , "Xing, Beilei" , "Zhang, Helin" , "Lu, Wenzhuo" Return-path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 642211E33 for ; Mon, 15 Jan 2018 05:57:58 +0100 (CET) In-Reply-To: <1515924222-19044-1-git-send-email-xiangxia.m.yue@gmail.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: xiangxia.m.yue@gmail.com [mailto:xiangxia.m.yue@gmail.com] > Sent: Sunday, January 14, 2018 6:04 PM > To: Dai, Wei ; Xing, Beilei > Cc: dev@dpdk.org; Tonghao Zhang > Subject: [PATCH v3 1/6] net/ixgbevf: unregister irq handler when other > interrupts not allowed. >=20 > From: Tonghao Zhang >=20 > When bind the ixgbe VF (e.g 82599 card) to igb_uio and enable the > rx-interrupt, there will be more than one epoll_wait on intr_handle.fd. > One is in "eal-intr-thread" thread, and the others are in the thread whic= h call > the "rte_epoll_wait". The problem is that sometimes "eal-intr-thread" thr= ead > will process the rx interrupt, and then rte_epoll_wait can't get the even= t > anymore, and the packets may be lost. >=20 > The patch unregister the status interrupt handler in "eal-intr-thread" > thread and the ixgbe pf is in the same case. >=20 > Signed-off-by: Tonghao Zhang > Acked-by: Beilei Xing In my feedback to your v2 version of this patch, I mentioned miscellaneous = interrupt need to be handled in eal-intr-thread.=20 Your patch removes the handler of PF->VF reset event and leads to missing o= f=20 this event. My suggestion is still using VFIO-PCI instead of igb_uio for rx-queue inter= rupt. > --- > drivers/net/ixgbe/ixgbe_ethdev.c | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) >=20 > diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c > b/drivers/net/ixgbe/ixgbe_ethdev.c > index ff19a56..0e056a2 100644 > --- a/drivers/net/ixgbe/ixgbe_ethdev.c > +++ b/drivers/net/ixgbe/ixgbe_ethdev.c > @@ -5078,6 +5078,15 @@ static int > ixgbevf_dev_xstats_get_names(__rte_unused struct rte_eth_dev *dev, > } > ixgbevf_configure_msix(dev); >=20 > + if (!rte_intr_allow_others(intr_handle)) { > + rte_intr_callback_unregister(intr_handle, > + ixgbevf_dev_interrupt_handler, > + dev); > + if (dev->data->dev_conf.intr_conf.lsc !=3D 0) > + PMD_INIT_LOG(INFO, "lsc won't enable because of" > + " no intr multiplex"); > + } > + > /* When a VF port is bound to VFIO-PCI, only miscellaneous interrupt > * is mapped to VFIO vector 0 in eth_ixgbevf_dev_init( ). > * If previous VFIO interrupt mapping setting in eth_ixgbevf_dev_init( = ) > @@ -5120,6 +5129,12 @@ static int > ixgbevf_dev_xstats_get_names(__rte_unused struct rte_eth_dev *dev, >=20 > ixgbe_dev_clear_queues(dev); >=20 > + if (!rte_intr_allow_others(intr_handle)) > + /* resume to the default handler */ > + rte_intr_callback_register(intr_handle, > + ixgbevf_dev_interrupt_handler, > + (void *)dev); > + > /* Clean datapath event and queue/vec mapping */ > rte_intr_efd_disable(intr_handle); > if (intr_handle->intr_vec !=3D NULL) { > -- > 1.8.3.1