From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Dai, Wei" Subject: Re: [PATCH v4 1/3] ethdev: add enum type for loop on Rx/Tx offloads Date: Tue, 20 Mar 2018 01:52:03 +0000 Message-ID: <49759EB36A64CF4892C1AFEC9231E8D66CF60976@PGSMSX112.gar.corp.intel.com> References: <1521293510-31421-1-git-send-email-wei.dai@intel.com> <1521463235-16451-1-git-send-email-wei.dai@intel.com> <1521463235-16451-2-git-send-email-wei.dai@intel.com> <039ED4275CED7440929022BC67E706115316FAB1@SHSMSX103.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: "dev@dpdk.org" To: "Zhang, Qi Z" , "Lu, Wenzhuo" , "Wu, Jingjing" Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 63FD55F34 for ; Tue, 20 Mar 2018 02:52:10 +0100 (CET) In-Reply-To: <039ED4275CED7440929022BC67E706115316FAB1@SHSMSX103.ccr.corp.intel.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Zhang Qi Thanks for your feedback. > -----Original Message----- > From: Zhang, Qi Z > Sent: Monday, March 19, 2018 10:06 PM > To: Dai, Wei ; Lu, Wenzhuo ; > Wu, Jingjing > Cc: dev@dpdk.org; Dai, Wei > Subject: RE: [dpdk-dev] [PATCH v4 1/3] ethdev: add enum type for loop on > Rx/Tx offloads >=20 > Hi Daiwei: >=20 > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wei Dai > > Sent: Monday, March 19, 2018 8:41 PM > > To: Lu, Wenzhuo ; Wu, Jingjing > > > > Cc: dev@dpdk.org; Dai, Wei > > Subject: [dpdk-dev] [PATCH v4 1/3] ethdev: add enum type for loop on > > Rx/Tx offloads > > > > This patch adds enum rte_eth_rx_offload_type and enum > > rte_eth_tx_offload_type. For a loop on all Rx offloads, it is > > convenient to begin with the first enum member > > ETH_RX_OFFLOAD_FIRST_FEATURE and to end at > ETH_RX_OFFLOAD_TOTAL_NUM. > > A loop on all Tx offloads can begin with > ETH_TX_OFFLOAD_FIRST_FEATURE > > and end at ETH_TX_OFFLOAD_TOTAL_NUM. > > > > Signed-off-by: Wei Dai > > --- > > lib/librte_ether/rte_ethdev.h | 44 > > +++++++++++++++++++++++++++++++++++++++++++ > > 1 file changed, 44 insertions(+) > > > > diff --git a/lib/librte_ether/rte_ethdev.h > > b/lib/librte_ether/rte_ethdev.h index 0361533..0089ea3 100644 > > --- a/lib/librte_ether/rte_ethdev.h > > +++ b/lib/librte_ether/rte_ethdev.h > > @@ -946,6 +946,27 @@ struct rte_eth_conf { > > DEV_RX_OFFLOAD_VLAN_FILTER | \ > > DEV_RX_OFFLOAD_VLAN_EXTEND) > > > > +enum rte_eth_rx_offload_type { > > + ETH_RX_OFFLOAD_FIRST_FEATURE =3D 0, > > + ETH_RX_OFFLOAD_VLAN_STRIP =3D ETH_RX_OFFLOAD_FIRST_FEATURE, > > + ETH_RX_OFFLOAD_IPV4_CKSUM, > > + ETH_RX_OFFLOAD_UDP_CKSUM, > > + ETH_RX_OFFLOAD_TCP_CKSUM, > > + ETH_RX_OFFLOAD_TCP_LRO, > > + ETH_RX_OFFLOAD_QINQ_STRIP, > > + ETH_RX_OFFLOAD_OUTER_IPV4_CKSUM, > > + ETH_RX_OFFLOAD_MACSEC_STRIP, > > + ETH_RX_OFFLOAD_HEADER_SPLIT, > > + ETH_RX_OFFLOAD_VLAN_FILTER, > > + ETH_RX_OFFLOAD_VLAN_EXTEND, > > + ETH_RX_OFFLOAD_JUMBO_FRAME, > > + ETH_RX_OFFLOAD_CRC_STRIP, > > + ETH_RX_OFFLOAD_SCATTER, > > + ETH_RX_OFFLOAD_TIMESTAMP, > > + ETH_RX_OFFLOAD_SECURITY, > > + ETH_RX_OFFLOAD_TOTAL_NUM > > +}; >=20 > This looks a little duplicate with rte_rx_offload_names in rte_ethdev.c rte_rx_offload_names is a static string array defined in rte_ethdev.c, if i= t can be referred by other files, the "static" must be removed. >=20 > In patch 2/3 and 3/3, I think if you simply loop from offload bit 0 to bi= t 63 to > check the name, that should still work right? > then this patch could be unnecessary. Yes, using loop from bit 0 to bit 63 in patch 2/3 and 3/3 can work right. But I think this enum type is still useful for other application which need= to loop on all possible offloads.=20 I will submit this patch as a standalone one and using loop from bit 0 to b= it 63 in next version of patch set. > Regards > Qi > > + > > /* > > * If new Rx offload capabilities are defined, they also must be > > * mentioned in rte_rx_offload_names in rte_ethdev.c file. > > @@ -981,6 +1002,29 @@ struct rte_eth_conf { > > */ > > #define DEV_TX_OFFLOAD_SECURITY 0x00020000 > > > > +enum rte_eth_tx_offload_type { > > + ETH_TX_OFFLOAD_FIRST_FEATURE =3D 0, > > + ETH_TX_OFFLOAD_VLAN_INSERT =3D ETH_TX_OFFLOAD_FIRST_FEATURE, > > + ETH_TX_OFFLOAD_IPV4_CKSUM, > > + ETH_TX_OFFLOAD_UDP_CKSUM, > > + ETH_TX_OFFLOAD_TCP_CKSUM, > > + ETH_TX_OFFLOAD_SCTP_CKSUM, > > + ETH_TX_OFFLOAD_TCP_TSO, > > + ETH_TX_OFFLOAD_UDP_TSO, > > + ETH_TX_OFFLOAD_OUTER_IPV4_CKSUM, > > + ETH_TX_OFFLOAD_QINQ_INSERT, > > + ETH_TX_OFFLOAD_VXLAN_TNL_TSO, > > + ETH_TX_OFFLOAD_GRE_TNL_TSO, > > + ETH_TX_OFFLOAD_IPIP_TNL_TSO, > > + ETH_TX_OFFLOAD_GENEVE_TNL_TSO, > > + ETH_TX_OFFLOAD_MACSEC_INSERT, > > + ETH_TX_OFFLOAD_MT_LOCKFREE, > > + ETH_TX_OFFLOAD_MULTI_SEGS, > > + ETH_TX_OFFLOAD_MBUF_FAST_FREE, > > + ETH_TX_OFFLOAD_SECURITY, > > + ETH_TX_OFFLOAD_TOTAL_NUM > > +}; > > + > > /* > > * If new Tx offload capabilities are defined, they also must be > > * mentioned in rte_tx_offload_names in rte_ethdev.c file. > > -- > > 2.7.5