All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Davis <afd@ti.com>
To: Randolph Sapp <rs@ti.com>, <jyri.sarha@iki.fi>, <tomba@kernel.org>
Cc: a-bhatia1@ti.com, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm: tidss: Fix pixel format definition
Date: Fri, 2 Dec 2022 11:52:12 -0600	[thread overview]
Message-ID: <49761fcd-7cef-9c41-185a-0a6d7e2b4a5e@ti.com> (raw)
In-Reply-To: <20221202001803.1765805-1-rs@ti.com>

On 12/1/22 6:18 PM, Randolph Sapp wrote:
> There was a long-standing bug from a typo that created 2 ARGB1555 and
> ABGR1555 pixel format entries. Weston 10 has a sanity check that alerted
> me to this issue.
> 
> According to the Supported Pixel Data formats table we have the later
> entries should have been for Alpha-X instead.
> 

Fixes 32a1795f57eecc

Acked-by: Andrew Davis <afd@ti.com>

> Signed-off-by: Randolph Sapp <rs@ti.com>
> ---
>   drivers/gpu/drm/tidss/tidss_dispc.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/tidss/tidss_dispc.c b/drivers/gpu/drm/tidss/tidss_dispc.c
> index ad93acc9abd2..16301bdfead1 100644
> --- a/drivers/gpu/drm/tidss/tidss_dispc.c
> +++ b/drivers/gpu/drm/tidss/tidss_dispc.c
> @@ -1858,8 +1858,8 @@ static const struct {
>   	{ DRM_FORMAT_XBGR4444, 0x21, },
>   	{ DRM_FORMAT_RGBX4444, 0x22, },
>   
> -	{ DRM_FORMAT_ARGB1555, 0x25, },
> -	{ DRM_FORMAT_ABGR1555, 0x26, },
> +	{ DRM_FORMAT_XRGB1555, 0x25, },
> +	{ DRM_FORMAT_XBGR1555, 0x26, },
>   
>   	{ DRM_FORMAT_XRGB8888, 0x27, },
>   	{ DRM_FORMAT_XBGR8888, 0x28, },

  reply	other threads:[~2022-12-02 17:52 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-02  0:18 [PATCH] drm: tidss: Fix pixel format definition Randolph Sapp
2022-12-02 17:52 ` Andrew Davis [this message]
2022-12-05  5:24   ` Aradhya Bhatia
2022-12-16  8:16 ` Tomi Valkeinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49761fcd-7cef-9c41-185a-0a6d7e2b4a5e@ti.com \
    --to=afd@ti.com \
    --cc=a-bhatia1@ti.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jyri.sarha@iki.fi \
    --cc=rs@ti.com \
    --cc=tomba@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.