From: Guenter Roeck <linux@roeck-us.net>
To: Henk <henk.vergonet@gmail.com>
Cc: linux-hwmon@vger.kernel.org
Subject: Re: [PATCH] hwmon: nct6775: Add missing voltage reading NCT6796D
Date: Wed, 14 Jul 2021 08:26:43 -0700 [thread overview]
Message-ID: <497f1c35-6334-7bf3-d72c-6f0db16bad4e@roeck-us.net> (raw)
In-Reply-To: <CAMFK4TMKt3myPKrLYU_vvC=PxxbdohyePZA9Qy0ygdtTmAZU6w@mail.gmail.com>
On 7/14/21 7:28 AM, Henk wrote:
> Can you be more specific?
>
Not a single one of your patch submissions followed the guidelines in
Documentation/process/submitting-patches.rst. Most common violations are:
- No or insufficient patch description
See 'Describe your changes'
- Patch sent as attachment
See 'No MIME, no links, no compression, no attachments. Just plain text'
- Instead of sending a patch, sent pointer to github location
You could just set up git send-email and use it to send your patches,
as suggested in submitting-patches.rst. Not doing that has cost both
of us a lot of time, for no good reason. I don't know about your time,
but I am not getting paid for my work as Linux kernel maintainer,
and my time is limited.
You for sure have accomplished one thing: A new formletter.
<Formletter>
Please follow the guidelines in
Documentation/hwmon/submitting-patches.rst
Documentation/process/submitting-patches.rst
when submitting patches into the hardware monitoring subsystem.
Patches not following those guidelines will be ignored.
</Formletter>
Guenter
> Op wo 14 jul. 2021 om 13:00 schreef Guenter Roeck <linux@roeck-us.net>:
>>
>> On 7/14/21 2:48 AM, Henk wrote:
>>> The nuvoton driver has quite some longstanding issues, as far as I can
>>> tell the alarm bits and input registers are not properly configured
>>> for a bunch of the chips.
>>> And this patch only addresses a tiny proportion of the issues.
>>>
>>> It would be helpful to get some meaningful feedback.
>>>
>>> Is there at least any interest in solving this issue?
>>>
>>
>> There is a lot of interest, but you'll have to do your part and send
>> patches in an acceptable form. So far you have not done that.
>>
>> Guenter
next prev parent reply other threads:[~2021-07-14 15:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <202107080039.1680d7Eo018443@systol.god.lan>
2021-07-08 0:42 ` Fwd: [PATCH] hwmon: nct6775: Add missing voltage reading NCT6796D Henk
2021-07-14 9:48 ` Henk
2021-07-14 11:00 ` Guenter Roeck
2021-07-14 14:28 ` Henk
2021-07-14 15:26 ` Guenter Roeck [this message]
2021-07-16 10:20 ` Henk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=497f1c35-6334-7bf3-d72c-6f0db16bad4e@roeck-us.net \
--to=linux@roeck-us.net \
--cc=henk.vergonet@gmail.com \
--cc=linux-hwmon@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.