From mboxrd@z Thu Jan 1 00:00:00 1970 From: Grzegorz Bernacki Date: Thu, 29 Jan 2009 09:56:32 +0100 Subject: [U-Boot] [PATCH] Add support for the digsy MTC board. In-Reply-To: <20090128210559.8CF2A832E416@gemini.denx.de> References: <12331552753467-git-send-email-gjb@semihalf.com> <20090128210559.8CF2A832E416@gemini.denx.de> Message-ID: <49816F40.3000201@semihalf.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Wolfgang Denk wrote: > Dear Grzegorz, > > In message <12331552753467-git-send-email-gjb@semihalf.com> you wrote: >> This is the InterControl custom device based on the MPC5200B chip. > ... > > General comment: there is a lot of code which could use a few comments > so the reader has a chance to understand what exactly you are doing. > Could you point me out which parts of code except eeprom defines needs more comments? > >> diff --git a/cpu/mpc5xxx/ide.c b/cpu/mpc5xxx/ide.c >> index df5b4ac..07d33e3 100644 >> --- a/cpu/mpc5xxx/ide.c >> +++ b/cpu/mpc5xxx/ide.c >> @@ -12,7 +12,7 @@ >> * >> * This program is distributed in the hope that it will be useful, >> * but WITHOUT ANY WARRANTY; without even the implied warranty of >> - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >> * GNU General Public License for more details. >> * >> * You should have received a copy of the GNU General Public License > > Please don't arbitrarily reformat the code. > I think this tab was inserted by mistake. In u-boot code there are both versions of license with and without this tab. Do you really want to leave it? pozdrawiam, Grzesiek