From: Jerry Van Baren <gerald.vanbaren@ge.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Add support for the digsy MTC board.
Date: Thu, 29 Jan 2009 07:51:58 -0500 [thread overview]
Message-ID: <4981A66E.1080005@ge.com> (raw)
In-Reply-To: <20090129105205.68BF1832E416@gemini.denx.de>
Wolfgang Denk wrote:
> Dear Grzegorz Bernacki,
>
> In message <49816F40.3000201@semihalf.com> you wrote:
[snip]
>>>> * This program is distributed in the hope that it will be useful,
>>>> * but WITHOUT ANY WARRANTY; without even the implied warranty of
>>>> - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
>>>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
>>>> * GNU General Public License for more details.
>>>> *
>>>> * You should have received a copy of the GNU General Public License
>>> Please don't arbitrarily reformat the code.
>> I think this tab was inserted by mistake. In u-boot code there are both
>> versions of license with and without this tab. Do you really want to
>> leave it?
>
> The original form of the code has 2 spaces there, as usual after a
> full stop. It seems this file has been run through "unexpand -a" (or
> an equivalent command), which inserted a TAB instead of the two
> spaces. This seems no problem to me, as the text still looks exactly
> the same (and we same one byte of disk storage :-).
Ahh, but two spaces vs. one tab have different meanings. They just
happen to look the same at the moment (blithely ignoring the fact that
this particular line of text isn't likely to change).
IMHO, replacing the two spaces with a tab was inadvertent whitespace
damage apparently due to a whitespace cleanup and should be fixed back
to being two spaces in all the header files.
> Your patch makes the text look different, and the change is to the
> worse.
>
> Best regards,
>
> Wolfgang Denk
Painting the bike shed,
gvb
next prev parent reply other threads:[~2009-01-29 12:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-28 15:07 [U-Boot] [PATCH] Add support for the digsy MTC board Grzegorz Bernacki
2009-01-28 21:05 ` Wolfgang Denk
2009-01-29 8:56 ` Grzegorz Bernacki
2009-01-29 10:52 ` Wolfgang Denk
2009-01-29 11:09 ` Grzegorz Bernacki
2009-01-29 12:51 ` Jerry Van Baren [this message]
2009-02-03 10:05 ` Grzegorz Bernacki
2009-02-12 9:21 Grzegorz Bernacki
2009-02-12 9:49 ` Stefan Roese
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4981A66E.1080005@ge.com \
--to=gerald.vanbaren@ge.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.