From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Toshi Kani <toshi.kani@hp.com>
Cc: ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>, Len Brown <lenb@kernel.org>,
Matthew Garrett <mjg59@srcf.ucam.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Yinghai Lu <yinghai@kernel.org>
Subject: Re: [PATCH] ACPI: Remove useless type argument of driver .remove() operation
Date: Tue, 22 Jan 2013 23:05:45 +0100 [thread overview]
Message-ID: <4985933.byC9yivxkj@vostro.rjw.lan> (raw)
In-Reply-To: <1358889867.14145.354.camel@misato.fc.hp.com>
On Tuesday, January 22, 2013 02:24:27 PM Toshi Kani wrote:
> On Sun, 2013-01-20 at 23:04 +0100, Rafael J. Wysocki wrote:
> > From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> >
> > The second argument of ACPI driver .remove() operation is only used
> > by the ACPI processor driver and the value passed to that driver
> > through it is always available from the given struct acpi_device
> > object's removal_type field. For this reason, the second ACPI driver
> > .remove() argument is in fact useless, so drop it.
> >
> > Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>
> Thanks for the clean-up! It looks good.
>
> Acked-by: Toshi Kani <toshi.kani@hp.com>
Thanks!
Rafael
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
prev parent reply other threads:[~2013-01-22 21:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-20 22:04 [PATCH] ACPI: Remove useless type argument of driver .remove() operation Rafael J. Wysocki
2013-01-20 22:06 ` Rafael J. Wysocki
2013-01-22 21:54 ` Yinghai Lu
2013-01-22 22:03 ` Rafael J. Wysocki
2013-01-22 22:25 ` [PATCH] ACPI: Drop device start operation that is not used Rafael J. Wysocki
2013-01-22 22:14 ` Toshi Kani
2013-01-22 22:20 ` Yinghai Lu
2013-01-21 16:08 ` [PATCH] ACPI: Remove useless type argument of driver .remove() operation Jiang Liu
2013-01-21 22:46 ` Rafael J. Wysocki
2013-01-22 21:24 ` Toshi Kani
2013-01-22 22:05 ` Rafael J. Wysocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4985933.byC9yivxkj@vostro.rjw.lan \
--to=rjw@sisk.pl \
--cc=bhelgaas@google.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg59@srcf.ucam.org \
--cc=toshi.kani@hp.com \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.