From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LTe7S-0001ut-Gm
	for qemu-devel@nongnu.org; Sun, 01 Feb 2009 10:20:22 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LTe7O-0001u2-B4
	for qemu-devel@nongnu.org; Sun, 01 Feb 2009 10:20:21 -0500
Received: from [199.232.76.173] (port=43464 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LTe7O-0001tz-42
	for qemu-devel@nongnu.org; Sun, 01 Feb 2009 10:20:18 -0500
Received: from mx2.redhat.com ([66.187.237.31]:38377)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <uril@redhat.com>) id 1LTe7N-0000w0-G4
	for qemu-devel@nongnu.org; Sun, 01 Feb 2009 10:20:17 -0500
Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26])
	by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n11FKGqD031615
	for <qemu-devel@nongnu.org>; Sun, 1 Feb 2009 10:20:16 -0500
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199])
	by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n11FKGD4016176
	for <qemu-devel@nongnu.org>; Sun, 1 Feb 2009 10:20:16 -0500
Received: from [10.35.1.187] (dhcp-1-187.tlv.redhat.com [10.35.1.187])
	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n11FKFsf025312
	for <qemu-devel@nongnu.org>; Sun, 1 Feb 2009 10:20:16 -0500
Message-ID: <4985BDB0.4090803@redhat.com>
Date: Sun, 01 Feb 2009 17:20:16 +0200
From: Uri Lublin <uril@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] (no subject)
References: <1233258889-6878-1-git-send-email-uril@redhat.com>
	<200901300243.23382.paul@codesourcery.com>
In-Reply-To: <200901300243.23382.paul@codesourcery.com>
Content-Type: text/plain; charset=iso-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Paul Brook wrote:
> On Thursday 29 January 2009, Uri Lublin wrote:
>> The following patch fixes saving/loading/migrating a VM with
>> multiple e1000 NICs.
> 
> I don't know what problems you're seeing, but this is definitely not the right 
> way to fix them.
> 
>> It turns out many devices use -1 as instance (for register_savevm),
>> which is wrong in cases where there can exist multiple such
>> devices within a single VM.
> 
> No it isn't. -1 means automatically assign IDs, and is what everything should 
> be using. The explicit ID argument is a historcal wart. Read the comment 
> above register_savevm.
> 
> Paul
> 

Paul,

You are right, I was wrong.
This patch is a fix for an older qemu, and is not needed.

Thanks for catching that,
     Uri.