From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94BBCC433E0 for ; Sat, 20 Feb 2021 22:01:57 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D29C864EB8 for ; Sat, 20 Feb 2021 22:01:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D29C864EB8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=eik.bme.hu Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:58372 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lDaK3-0002s5-Or for qemu-devel@archiver.kernel.org; Sat, 20 Feb 2021 17:01:55 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:45402) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lDaIo-0002MT-NI for qemu-devel@nongnu.org; Sat, 20 Feb 2021 17:00:38 -0500 Received: from zero.eik.bme.hu ([2001:738:2001:2001::2001]:22892) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lDaIl-0001Kk-On for qemu-devel@nongnu.org; Sat, 20 Feb 2021 17:00:38 -0500 Received: from zero.eik.bme.hu (blah.eik.bme.hu [152.66.115.182]) by localhost (Postfix) with SMTP id E46337462BD; Sat, 20 Feb 2021 23:00:26 +0100 (CET) Received: by zero.eik.bme.hu (Postfix, from userid 432) id B64BC74581E; Sat, 20 Feb 2021 23:00:26 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by zero.eik.bme.hu (Postfix) with ESMTP id B55717456E3; Sat, 20 Feb 2021 23:00:26 +0100 (CET) Date: Sat, 20 Feb 2021 23:00:26 +0100 (CET) From: BALATON Zoltan To: =?ISO-8859-15?Q?Philippe_Mathieu-Daud=E9?= Subject: Re: [PATCH v2 09/13] vt82c686: Fix superio_cfg_{read,write}() functions In-Reply-To: Message-ID: <498cdf92-f0f6-9ad6-9da6-63c5bd93b8@eik.bme.hu> References: <15b2968fd300a12d06b42368d084f6f80d3c3be5.1610223397.git.balaton@eik.bme.hu> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="3866299591-571240357-1613858426=:95909" Received-SPF: pass client-ip=2001:738:2001:2001::2001; envelope-from=balaton@eik.bme.hu; helo=zero.eik.bme.hu X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Huacai Chen , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --3866299591-571240357-1613858426=:95909 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8BIT On Sat, 20 Feb 2021, Philippe Mathieu-Daudé wrote: > On 1/9/21 9:16 PM, BALATON Zoltan wrote: >> These functions are memory region callbacks so we have to check >> against relative address not the mapped address. Also reduce >> indentation by returning early and log unimplemented accesses. >> Additionally we remove separate index value from SuperIOConfig and >> store the index at reg 0 which is reserved and returns 0 on read. This >> simplifies object state. > > Again... Why are you putting so many changes in the same patch? I thought these changes were simple enough to include in one patch so I don't get a series with 25 one line patches when I already have 13 patches. Also I've split these up after having it working and it was hard to separate changes after the fact even if I went through doing it again from scratch to create the separate patches. > I split it in 5 distinct patches trivial to review. I probably > shouldn't spend that amount of maintainer time with your series, > but this time I did it, my bad. You don't have to do that, you can just tell me in review how you want these split up and then I can change it accordingly. Thanks a lot for doing it though, I can't see how this patch could be split up more than intno 2-3 patches so doing it was probably faster than explaining it in this case. Regards, BALATON Zoltan >> >> Signed-off-by: BALATON Zoltan >> --- >> hw/isa/vt82c686.c | 63 ++++++++++++++++++++++++++--------------------- >> 1 file changed, 35 insertions(+), 28 deletions(-) > > --3866299591-571240357-1613858426=:95909--