From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>,
Tudor Cornea <tudor.cornea@gmail.com>
Cc: <padraig.j.connolly@intel.com>, <thomas@monjalon.net>,
<helin.zhang@intel.com>, <dev@dpdk.org>
Subject: Re: [PATCH v5] kni: allow configuring the kni thread granularity
Date: Fri, 14 Jan 2022 16:43:53 +0000 [thread overview]
Message-ID: <49900a8c-f9d1-f69f-04f8-b49a4aeebd5e@intel.com> (raw)
In-Reply-To: <20220114082415.69752802@hermes.local>
On 1/14/2022 4:24 PM, Stephen Hemminger wrote:
> On Fri, 14 Jan 2022 17:18:19 +0200
> Tudor Cornea <tudor.cornea@gmail.com> wrote:
>
>> +module_param(min_scheduling_interval, long, 0644);
>> +MODULE_PARM_DESC(min_scheduling_interval,
>> +"\t\tKni thread min scheduling interval (default=100 microseconds):\n"
>> +"\t\t"
>> +);
>> +
>> +module_param(max_scheduling_interval, long, 0644);
>> +MODULE_PARM_DESC(max_scheduling_interval,
>> +"\t\tKni thread max scheduling interval (default=200 microseconds):\n"
>> +"\t\t"
>> +);
>
> Please don't add more bad module parameter strings.
> The KNI author did something no other kernel modules do with tabs
> and double spacing, stop this bogus stuff.
>
The patch is good, let's not block it for the module parameter string,
all can be fixed with another patch.
Can you please give a sample what is a common way of it, me or Tudor can
do the patch?
> Is there any reason you have to use KNI at all.
> KNI is broken on many levels and is not fixable.
> What about virtio or tap?
next prev parent reply other threads:[~2022-01-14 16:44 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-02 10:38 [dpdk-dev] [PATCH] kni: allow configuring the kni thread granularity Tudor Cornea
2021-11-02 15:51 ` [dpdk-dev] [PATCH v2] " Tudor Cornea
2021-11-02 15:53 ` Stephen Hemminger
2021-11-03 20:40 ` Tudor Cornea
2021-11-03 22:18 ` Stephen Hemminger
2021-11-08 10:13 ` [dpdk-dev] [PATCH v3] " Tudor Cornea
2021-11-22 17:31 ` Ferruh Yigit
2021-11-23 17:08 ` Ferruh Yigit
2021-11-24 17:10 ` Tudor Cornea
2021-11-24 19:24 ` [PATCH v4] " Tudor Cornea
2022-01-14 13:53 ` Connolly, Padraig J
2022-01-14 14:13 ` Ferruh Yigit
2022-01-14 15:18 ` [PATCH v5] " Tudor Cornea
2022-01-14 16:24 ` Stephen Hemminger
2022-01-14 16:43 ` Ferruh Yigit [this message]
2022-01-17 16:24 ` Tudor Cornea
2022-01-20 12:41 ` [PATCH v6] " Tudor Cornea
2022-02-02 19:30 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49900a8c-f9d1-f69f-04f8-b49a4aeebd5e@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=helin.zhang@intel.com \
--cc=padraig.j.connolly@intel.com \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
--cc=tudor.cornea@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.