Re: [PATCHv7] lis3lv02d: support both one- and two-byte sensors

From: "Éric Piel" <eric.piel@tremplin-utc.net>
To: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>,
	Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, Pavel Machek <pavel@suse.cz>
Subject: Re: [PATCHv7] lis3lv02d: support both one- and two-byte sensors
Date: Wed, 11 Feb 2009 11:17:10 +0100	[thread overview]
Message-ID: <4992A5A6.5000707@tremplin-utc.net> (raw)
In-Reply-To: <1234346803-19811-1-git-send-email-giuseppe.bilotta@gmail.com>

Giuseppe Bilotta schreef:
> Sensors responding with 0x3B to WHO_AM_I only have one data register per
> direction, thus returning a signed byte from the position which is
> occupied by the MSB in sensors responding with 0x3A.
> 
> Since multiple sensors share the reply to WHO_AM_I, we rename the
> defines to better indicate what they identify (family of single and
> double precision sensors).
> 
> We support both kind of sensors by checking for the sensor type on init
> and defining appropriate data-access routines and sensor limits (for the
> joystick) depending on what we find.
> 
> Signed-off-by: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
Acked-by: Eric Piel <Eric.Piel@tremplin-utc.net>

Andrew, could you queue it? This should fix problems with a certain
number of laptops which were supposedly supported but in practice were
not usable.

Thanks,
Eric