From mboxrd@z Thu Jan 1 00:00:00 1970 From: Soeren Moch Date: Thu, 30 Jan 2020 23:14:05 +0100 Subject: [PATCH v2][ 3/3] board: tbs2910: Add support for generic distro configuration In-Reply-To: <20200128222732.20ac476f@primarylaptop.localdomain> References: <20200128170418.15912-1-GNUtoo@cyberdimension.org> <20200128170418.15912-3-GNUtoo@cyberdimension.org> <598f8fa5-3782-34c0-327e-d95e47def145@web.de> <20200128222732.20ac476f@primarylaptop.localdomain> Message-ID: <49930991-4843-f534-66d6-fe9b67d13310@web.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable To: u-boot@lists.denx.de On 28.01.20 22:27, Denis 'GNUtoo' Carikli wrote: > On Tue, 28 Jan 2020 18:51:26 +0100 > Soeren Moch wrote: > >> As already discussed, the bootm_size environment variable is not >> necessary, otherwise=C2=A0 somewhat dangerous with this value. > Sorry, for the mistake, I've fixed it now. > > I'll send a v3 after some feedback from my response to your other > points. > > Thanks a lot for the reviews. For your v3 please drop patch 1/3, please disable CONFIG_GZIP instead. If you want to indicate the size reduction, please do so for u-boot.bin instead of u-boot.imx. And please only report the size reduction instead of absolute size values, as suggested by Fabio. For patch 2/3 please include my Acked-by, and update size reduction description as suggested above. Please split patch 3/3 into 3 separate patches: - Move (the existing) CONFIG_BOOTCOMMAND to defconfig. - Enable DISTRO_DEFAULTS in defconfig, in preparation of distro_boot support. Also do the defconfig sync here. - Enable distro_boot support. This includes the modified BOOTCOMMAND, DEFAULT_FDT_FILE,BOOT_TARGET_DEVICES, and environment update. For all patches please also Cc: Stefano and Fabio. Thanks, Soeren