From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1LXJpR-0000c5-Eg for mharc-grub-devel@gnu.org; Wed, 11 Feb 2009 13:28:57 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LXJpQ-0000bu-7J for grub-devel@gnu.org; Wed, 11 Feb 2009 13:28:56 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LXJpO-0000bi-Oy for grub-devel@gnu.org; Wed, 11 Feb 2009 13:28:54 -0500 Received: from [199.232.76.173] (port=51079 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LXJpO-0000bf-JT for grub-devel@gnu.org; Wed, 11 Feb 2009 13:28:54 -0500 Received: from fg-out-1718.google.com ([72.14.220.155]:45877) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LXJpN-0004Yo-6v for grub-devel@gnu.org; Wed, 11 Feb 2009 13:28:53 -0500 Received: by fg-out-1718.google.com with SMTP id l27so112861fgb.30 for ; Wed, 11 Feb 2009 10:28:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:subject:references:in-reply-to :content-type:content-transfer-encoding; bh=hXxVhPl8KYkNTW/FsvZNGvHG9oFD0rl9Z68Jnu0jKRQ=; b=VHs6x+uDB+qXS5nz4r8J45MNoxVsL3HgstY6NVMtxHIcllzHhKgh0jMoxgda4DTuvz bzoFt+5HqWJ4875fQ94zKqDSZCE4TYoBSwKl50VtB6kJmkqi0izEt7SYLrXk59d1a/Np 4WLxtFekhuCri05CgDDLuRThY5uAGaoAvhFUM= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type:content-transfer-encoding; b=mkfpk+ZhFvfKmAmWUcvj15cPXi9OKdrnu1f+Q1pB5EZIR2Yv46qCig7vWn+eVcI+fr 3x1JtqLmBznY3dz41aR9NELHM+S7yjLME6qmXRJS2LnHskI4u0KjH4D0szcz/JUDzXOj W4N48FguXKltbV0vM57dJZLr6/pgGrekl1VyU= Received: by 10.86.60.14 with SMTP id i14mr865864fga.21.1234376932251; Wed, 11 Feb 2009 10:28:52 -0800 (PST) Received: from ?192.168.1.25? (230-40.1-85.cust.bluewin.ch [85.1.40.230]) by mx.google.com with ESMTPS id l19sm1274763fgb.47.2009.02.11.10.28.51 (version=SSLv3 cipher=RC4-MD5); Wed, 11 Feb 2009 10:28:51 -0800 (PST) Message-ID: <499318E3.5040801@gmail.com> Date: Wed, 11 Feb 2009 19:28:51 +0100 From: phcoder User-Agent: Thunderbird 2.0.0.19 (X11/20090105) MIME-Version: 1.0 To: The development of GRUB 2 References: <4992D603.9030105@gmail.com> <1234369601.25774.5.camel@mj> In-Reply-To: <1234369601.25774.5.camel@mj> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Subject: Re: [PATCH] make partition active X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Feb 2009 18:28:56 -0000 Pavel Roskin wrote: > On Wed, 2009-02-11 at 14:43 +0100, phcoder wrote: >> Here's the patch to add a replacement for old "makeactive" command >> New syntax is >> activate PARTITION >> E.g. >> activate hd0,1 > > Is it necessary to change the name? I think "makeactive" is a better > name for what it does. Actually I don't really care but on http://grub.enbug.org/CommandList it was suggested to change the name. But what I dislike is having this command without argument which always activates current root partition > > Maybe we could use a more generic solution, e.g. a command for setting > different flags (or "attributes" in GPT terminology), such as bootable, > read-only, hidden (that would apply only to some partition types in the > PC partition table) and so on. It's a good possibility but I don't want to encumber the partition module with non-essential functions since they're often integrated into core.img. But it's possible to have something like pctool hd0,1 boot+ hidden- gpttool hd0,1 ro+ (Actually I find the name "pc" unfortunate, IMO "fdisk" would be much better) It's also possible to write a wrapper parttool hd0,1 boot+ Which chooses the correct tool and launches it (a tool can be easily registered as a pair of partition style name and a function). In this case we wouldn't even need separate command for different partition style. We have however to find a way to list all available flags in help parttool Regards Vladimir 'phcoder' Serbinenko