All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Christie <michaelc@cs.wisc.edu>
To: open-iscsi@googlegroups.com
Cc: linux-scsi@vger.kernel.org, kxie@chelsio.com,
	James.Bottomley@HansenPartnership.com
Subject: Re: [PATCH 2.6.29-rc] iscsi - add offset and count to alloc_pdu()
Date: Wed, 11 Feb 2009 13:57:21 -0600	[thread overview]
Message-ID: <49932DA1.8030704@cs.wisc.edu> (raw)
In-Reply-To: <200902110301.n1B31q5M002101@localhost.localdomain>

Karen Xie wrote:
> [PATCH 2.6.29-rc] iscsi - add offset and count to alloc_pdu().
> 
> From: Karen Xie <kxie@chelsio.com>
> 
> Hi, Mike,
> 
> I looked through libiscsi.c, libiscsi_tcp.c and iscsi_tcp.c. It does seem to be a little messy to merge the two functions. Especially the BHS is constructed after pdu_alloc(), and iscsi_tcp uses the BHS fields in init_pdu(). 
> 
> So I only added the offset and count as additional parameters to alloc_pdu(). So that the pdu payload is known at the time of pdu memory allocation.
> 

Ehhhhhh, yeah it is workable. Give me a day to check this out more. It 
makes the api akward because we get the data offset and len, but not the 
header. Let me see if I can build on your patch.

Thanks.

      parent reply	other threads:[~2009-02-11 19:57 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-11  3:01 [PATCH 2.6.29-rc] iscsi - add offset and count to alloc_pdu() Karen Xie
     [not found] ` <200902110301.n1B31q5M002101-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2009-02-11  8:21   ` Or Gerlitz
2009-02-11 19:57 ` Mike Christie [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49932DA1.8030704@cs.wisc.edu \
    --to=michaelc@cs.wisc.edu \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=kxie@chelsio.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=open-iscsi@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.