From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B70A9C4338F for ; Mon, 23 Aug 2021 09:37:10 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3A26261186 for ; Mon, 23 Aug 2021 09:37:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 3A26261186 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:48034 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mI6OD-0007M8-60 for qemu-devel@archiver.kernel.org; Mon, 23 Aug 2021 05:37:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38146) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mI6NL-0006gN-KF for qemu-devel@nongnu.org; Mon, 23 Aug 2021 05:36:15 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:52705) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mI6NK-0005CI-3S for qemu-devel@nongnu.org; Mon, 23 Aug 2021 05:36:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1629711373; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RAjeXvxFQzm8ZCaq1ZojnvnvGKAOe6InPVFXd2hB/ss=; b=ObA5afYTuWXIDLSdUhptL1v5/du7gJ48xvbwTdlhSOaTJfOJMeR9HDqbpnm5t7DnlJptY/ wjZuwhOXWWuPN1bVjheB5Pqy2SJfNIo+PmLA6motooyno33iVEeloin1ABBRIr83TAFMC7 89zyzLit9qr2spyMvo3Uu4u37gU2s8U= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-441-mZ_i0qWRNKqJSqwyt8Ux-w-1; Mon, 23 Aug 2021 05:36:10 -0400 X-MC-Unique: mZ_i0qWRNKqJSqwyt8Ux-w-1 Received: by mail-wm1-f69.google.com with SMTP id w25-20020a1cf6190000b0290252505ddd56so2788428wmc.3 for ; Mon, 23 Aug 2021 02:36:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=RAjeXvxFQzm8ZCaq1ZojnvnvGKAOe6InPVFXd2hB/ss=; b=IANdmMBwq94O8OIgC/taDupCdyr26XTW1wLVEJAQPbGrZp6FKePrZIf69yeU5UwThe k4j/QloEp3yTz/PxDUd9+ED5LhKubk/pNIJKae6bA3N70dUype8P03cBm5Gsl07StvoM bqcQQF5U0Lk3TGM7le5RahgNCCHE3TpmnXs/dUTkC8/ht79njL0905GPTBCpL4tUvTkO RcvmD0wbuBRH7004zTJ9ljwSSneV+3jVLg9D2K1w6BQEVlggRucYZqQebeJwhJNCoN0z yMSNhbO6Vuw5xWgi5uRL8CFF/OWqmJ9ViTkOs+sXJnmEfC+V0EVIs3+bWVuoFE2P6uhG Wyag== X-Gm-Message-State: AOAM5330XbmMUxPHegdZvrVslPTj8okslqiqL9pD/tBEtluu0ArKRKQ6 6o3owolTp5jf/Qxvyp6X2XLWiNK/C1Mpt1c7IfBjqpJR0Xt0ARfpzoOILO4R0guI26CzJ/5SrdA GAQihrkF12UKpF+s= X-Received: by 2002:a05:600c:4fc7:: with SMTP id o7mr8173554wmq.55.1629711369708; Mon, 23 Aug 2021 02:36:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx01kAd4spfqnugn8pZXZrAu+fWdkQVSRocw6deX/Mljj6t5ePBxI0rq3VAwwEUXXN4JXUrYQ== X-Received: by 2002:a05:600c:4fc7:: with SMTP id o7mr8173533wmq.55.1629711369489; Mon, 23 Aug 2021 02:36:09 -0700 (PDT) Received: from ?IPv6:2003:d8:2f0a:7f00:fad7:3bc9:69d:31f? (p200300d82f0a7f00fad73bc9069d031f.dip0.t-ipconnect.de. [2003:d8:2f0a:7f00:fad7:3bc9:69d:31f]) by smtp.gmail.com with ESMTPSA id g21sm17917704wmk.8.2021.08.23.02.36.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 Aug 2021 02:36:09 -0700 (PDT) Subject: Re: [PATCH v3] memory: Have 'info mtree' remove duplicated Address Space information To: Peter Maydell References: <20210823085429.597873-1-philmd@redhat.com> <8743192d-225d-c091-ab53-c747daa86f46@redhat.com> From: David Hildenbrand Organization: Red Hat Message-ID: <499a2d67-9234-30ec-2645-4e0f77dc336b@redhat.com> Date: Mon, 23 Aug 2021 11:35:57 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=david@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=david@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -44 X-Spam_score: -4.5 X-Spam_bar: ---- X-Spam_report: (-4.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.746, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.959, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Cave-Ayland , QEMU Developers , Peter Xu , Gerd Hoffmann , Paolo Bonzini , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 23.08.21 11:28, Peter Maydell wrote: > On Mon, 23 Aug 2021 at 10:20, David Hildenbrand wrote: >> >> On 23.08.21 10:54, Philippe Mathieu-Daudé wrote: >>> +static void mtree_print_as(gpointer key, gpointer value, gpointer user_data) >>> +{ >>> + MemoryRegion *mr = key; >>> + GSList *as_same_root_mr_list = value; >>> + struct AddressSpaceInfo *asi = user_data; >> >> Reverse Christmas tree? > > This has never been part of the QEMU style guidelines > and I would oppose our adding it. It would gain us very little, > the codebase doesn't consistently follow that rule today so > it wouldn't be preserving an existing consistency of style, > and it would be yet another weird stylistic issue that trips > people up and requires patch repins. Ah right, it used very inconsistently in the QEMU codebase and even in this file (I spotted it's the case in the entry of mtree_info() and wondered if it's the case for this file -- turns out it's absolutely not). -- Thanks, David / dhildenb