All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sven Schwermer <sven@svenschwermer.de>
To: Sven Schuchmann <schuchmann@schleissheimer.de>,
	"linux-leds@vger.kernel.org" <linux-leds@vger.kernel.org>
Cc: Jacek Anaszewski <jacek.anaszewski@gmail.com>,
	"pavel@ucw.cz" <pavel@ucw.cz>
Subject: Re: AW: [PATCH v2 1/2] dt-bindings: leds: Add multi-color default-intensities property
Date: Tue, 3 May 2022 20:58:51 +0200	[thread overview]
Message-ID: <499bce9d-81d1-8edb-3db5-187e86db71f4@svenschwermer.de> (raw)
In-Reply-To: <GVXP190MB19174C638935B1C6717F8AEBD9C09@GVXP190MB1917.EURP190.PROD.OUTLOOK.COM>

Hi Sven,

Thanks for making me aware of your patch series. My series would work 
similar to yours, i.e. the default-intensities property would be on the 
same level as color = <LED_COLOR_ID_RGB>.

However, the concern voiced by Jacek is relevant for my patch as well, 
see 
https://lore.kernel.org/all/d5631e35-cd62-106f-2ec4-de3163367bc0@gmail.com/
However, I do not know how to resolve the issue. Perhaps somebody from 
the list has ideas?

Best regards,
Sven

On 5/3/22 15:50, Sven Schuchmann wrote:
> Hello Sven,
> 
> tried this some time ago for the LP50XX
> https://lore.kernel.org/all/20210204143726.27977-1-schuchmann@schleissheimer.de/
> 
> Your solution looks much better.
> Could you give an example of how to use it?
> 
> My Configuration at this time looks like this:
> 
> multi-led@0 {
> 		#address-cells = <1>;
> 		#size-cells = <0>;
> 		reg = <0x0>;
> 		color = <LED_COLOR_ID_RGB>;
> 		function = "eee-led-status";
> 
> 		led-0 {
> 			color = <LED_COLOR_ID_RED>;
> 		};
> 
> 		led-1 {
> 			color = <LED_COLOR_ID_GREEN>;
> 		};
> 
> 		led-2 {
> 			color = <LED_COLOR_ID_BLUE>;
> 		};
> 	};
> 
> 
> Where do I put the "default-intensities"?
> 
> Regards,
> 
>     Sven
> 
>> -----Ursprüngliche Nachricht-----
>> Von: Sven Schwermer <sven@svenschwermer.de>
>> Gesendet: Dienstag, 3. Mai 2022 13:27
>> An: linux-leds@vger.kernel.org; linux-kernel@vger.kernel.org; pavel@ucw.cz;
>> robh+dt@kernel.org; krzysztof.kozlowski+dt@linaro.org; dmurphy@ti.com;
>> devicetree@vger.kernel.org
>> Cc: Sven Schwermer <sven.schwermer@disruptive-technologies.com>
>> Betreff: [PATCH v2 1/2] dt-bindings: leds: Add multi-color default-intensities property
>>
>> From: Sven Schwermer <sven.schwermer@disruptive-technologies.com>
>>
>> This allows to assign intensity values to the indivisual sub LEDs
>> (colors) at driver probe time, i.e. most commonly at kernel boot time.
>> This is crucial for setting a specific color early in the boot process.
>>
>> Signed-off-by: Sven Schwermer <sven.schwermer@disruptive-technologies.com>
>> ---
>>
>> Notes:
>>      V1->V2: no changes
>>
>>   .../devicetree/bindings/leds/leds-class-multicolor.yaml    | 7 +++++++
>>   1 file changed, 7 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/leds/leds-class-multicolor.yaml
>> b/Documentation/devicetree/bindings/leds/leds-class-multicolor.yaml
>> index 37445c68cdef..c483967a847c 100644
>> --- a/Documentation/devicetree/bindings/leds/leds-class-multicolor.yaml
>> +++ b/Documentation/devicetree/bindings/leds/leds-class-multicolor.yaml
>> @@ -31,6 +31,13 @@ patternProperties:
>>             include/linux/leds/common.h.
>>           enum: [ 8, 9 ]
>>
>> +      default-intensities:
>> +        description: |
>> +          This parameter, if present, sets the initial intensities of the
>> +          individual colors. This array must have the same length as the
>> +          multi-color LED has sub LEDs (colors).
>> +        $ref: /schemas/types.yaml#/definitions/uint32-array
>> +
>>       $ref: "common.yaml#"
>>
>>       required:
>> --
>> 2.36.0
> 

  reply	other threads:[~2022-05-03 18:59 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-02 14:09 Initial multicolor LED intensities Sven Schwermer
2022-05-02 20:46 ` Pavel Machek
2022-05-03 11:04   ` [PATCH v1 1/2] dt-bindings: leds: Add multi-color default-intensities property Sven Schwermer
2022-05-03 11:04     ` [PATCH v1 2/2] leds: multicolor: Read " Sven Schwermer
2022-05-03 11:27   ` [PATCH v2 1/2] dt-bindings: leds: Add multi-color " Sven Schwermer
2022-05-03 11:27     ` [PATCH v2 2/2] leds: multicolor: Read " Sven Schwermer
2022-05-03 13:50     ` AW: [PATCH v2 1/2] dt-bindings: leds: Add multi-color " Sven Schuchmann
2022-05-03 18:58       ` Sven Schwermer [this message]
2022-05-04  7:17         ` AW: " Sven Schuchmann
2022-05-04  9:24           ` Sven Schwermer
2022-05-08 19:55             ` Jacek Anaszewski
2022-05-10 18:31               ` Sven Schwermer
2022-05-10 22:00                 ` Jacek Anaszewski
2022-05-05  9:50   ` [PATCH v3 " Sven Schwermer
2022-05-05  9:50     ` [PATCH v3 2/2] leds: multicolor: Read " Sven Schwermer
2022-05-17  0:08     ` [PATCH v3 1/2] dt-bindings: leds: Add multi-color " Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=499bce9d-81d1-8edb-3db5-187e86db71f4@svenschwermer.de \
    --to=sven@svenschwermer.de \
    --cc=jacek.anaszewski@gmail.com \
    --cc=linux-leds@vger.kernel.org \
    --cc=pavel@ucw.cz \
    --cc=schuchmann@schleissheimer.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.