From: Avi Kivity <avi@redhat.com>
To: Mohammed Gamal <m.gamal005@gmail.com>
Cc: kvm@vger.kernel.org
Subject: Re: [PATCH] x86 emulator: Add pop es instruction (opcode 0x07)
Date: Thu, 26 Feb 2009 09:13:23 +0200 [thread overview]
Message-ID: <49A64113.1020002@redhat.com> (raw)
In-Reply-To: <20090225213929.GA22725@mohd-laptop>
Mohammed Gamal wrote:
> Add pop es instruction
>
>
Hi again...
> @@ -1446,6 +1446,9 @@ special_insn:
> add: /* add */
> emulate_2op_SrcV("add", c->src, c->dst, ctxt->eflags);
> break;
> + case 0x07: /* pop es */
> + emulate_pop(ctxt, ops, &c->regs[VCPU_SREG_ES], c->op_bytes);
> + break;
> case 0x08 ... 0x0d:
> or: /* or */
> emulate_2op_SrcV("or", c->src, c->dst, ctxt->eflags);
>
... but this is insufficient. You need to load the segment cache, see
kvm_load_segment_descriptor().
--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.
prev parent reply other threads:[~2009-02-26 7:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-25 21:39 [PATCH] x86 emulator: Add pop es instruction (opcode 0x07) Mohammed Gamal
2009-02-26 7:13 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49A64113.1020002@redhat.com \
--to=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=m.gamal005@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.