From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1Ldt5I-0002Re-RJ for mharc-grub-devel@gnu.org; Sun, 01 Mar 2009 16:20:28 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Ldt5G-0002Qr-Ff for grub-devel@gnu.org; Sun, 01 Mar 2009 16:20:26 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Ldt5F-0002QE-U3 for grub-devel@gnu.org; Sun, 01 Mar 2009 16:20:26 -0500 Received: from [199.232.76.173] (port=55530 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ldt5F-0002Q5-Qh for grub-devel@gnu.org; Sun, 01 Mar 2009 16:20:25 -0500 Received: from fg-out-1718.google.com ([72.14.220.157]:17132) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Ldt5F-0005Zh-Bs for grub-devel@gnu.org; Sun, 01 Mar 2009 16:20:25 -0500 Received: by fg-out-1718.google.com with SMTP id l27so849373fgb.30 for ; Sun, 01 Mar 2009 13:20:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:subject:references:in-reply-to :content-type:content-transfer-encoding; bh=FfBipkFBz3JI/yFx2z3wFWnYIjZuZnYAXe/76EIBG0w=; b=HCRRN5gJemBNf6qIxkjiE+YOIvLbnzZXPoZS7kAbJh4TL46d3P7+GJDHMO714NznZj HnDYHYj2qQjtowL/Q5IV6RC0YMRH4prtF+rsvB5nhiKv6pVu07vD7zgw4tIPgbVS5KM7 bn/ZoIfdS1NHW/SEqNN1PHJ2ik+BuBQWGoHpM= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type:content-transfer-encoding; b=cf9eb3mAQtpnEe+jBNGAksKwRJXMra4QDhyVMerPcYYe0+wCr+wllnEocwTnLTHaxY SdHAcuB2EwfNkHUa9RfB+Tt0dbiKBtqlcbpzIW0aaTw2+gnrl9adT/dlz/M9V+W1l71X oPcxXeiV8RSd1+yYkWbqF1dOkdCLm6uIIUXYE= Received: by 10.86.95.20 with SMTP id s20mr2922371fgb.40.1235942424592; Sun, 01 Mar 2009 13:20:24 -0800 (PST) Received: from ?192.168.1.2? (211-140.79-83.cust.bluewin.ch [83.79.140.211]) by mx.google.com with ESMTPS id l12sm5971768fgb.31.2009.03.01.13.20.23 (version=SSLv3 cipher=RC4-MD5); Sun, 01 Mar 2009 13:20:24 -0800 (PST) Message-ID: <49AAFC17.7040608@gmail.com> Date: Sun, 01 Mar 2009 22:20:23 +0100 From: phcoder User-Agent: Thunderbird 2.0.0.19 (X11/20090105) MIME-Version: 1.0 To: The development of GRUB 2 References: <4992D603.9030105@gmail.com> <1234369601.25774.5.camel@mj> <499318E3.5040801@gmail.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Subject: Re: [PATCH] make partition active X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 01 Mar 2009 21:20:26 -0000 Hello >> It's also possible to write a wrapper >> parttool hd0,1 boot+ >> >> Which chooses the correct tool and launches it (a tool can be easily >> registered as a pair of partition style name and a function). In this case >> we wouldn't even need separate command for different partition style. We >> have however to find a way to list all available flags in >> >> help parttool > > Hi, > > The patch looks fine to me, except for perhaps the name. activate > doesn't seems to suggest its function. Frankly, makeactive doesn't > make much sense as well, but at least it's already widely used in grub > legacy, old user could easily guess its function by name. > Then we could use parttool syntax. Then parttype can be implemented like grub> parttool hd0,1 type=7 makeactive like: grub> parttool hd0,1 boot+ And it can even be done by one command grub> parttool hd0,1 boot+ type=7 Thank you for your attention to my patches -- Regards Vladimir 'phcoder' Serbinenko