From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Leyfm-0007xB-In
	for qemu-devel@nongnu.org; Wed, 04 Mar 2009 16:30:38 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Leyfl-0007wT-9i
	for qemu-devel@nongnu.org; Wed, 04 Mar 2009 16:30:38 -0500
Received: from [199.232.76.173] (port=41623 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Leyfl-0007wO-42
	for qemu-devel@nongnu.org; Wed, 04 Mar 2009 16:30:37 -0500
Received: from moutng.kundenserver.de ([212.227.126.187]:49347)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <weil@mail.berlios.de>) id 1Leyfk-0000fn-E7
	for qemu-devel@nongnu.org; Wed, 04 Mar 2009 16:30:36 -0500
Received: from localhost ([127.0.0.1] ident=stefan)
	by flocke.weilnetz.de with esmtp (Exim 4.69)
	(envelope-from <weil@mail.berlios.de>) id 1Leyfh-0000Ky-Bo
	for qemu-devel@nongnu.org; Wed, 04 Mar 2009 22:30:33 +0100
Message-ID: <49AEF2F9.7060400@mail.berlios.de>
Date: Wed, 04 Mar 2009 22:30:33 +0100
From: Stefan Weil <weil@mail.berlios.de>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] Get sh right on OpenSolaris/SPARC
References: <Pine.NEB.4.64.0903022047120.15645@otaku.freeshell.org>
In-Reply-To: <Pine.NEB.4.64.0903022047120.15645@otaku.freeshell.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Palle Lyckegaard schrieb:
>
> The patch below solves a problem when building qemu on OpenSolaris/SPARC.
>
> "feature_to_c.sh: test: argument expected"
>
> There seemes to be a problem with how "features_to_c.sh" is started
> from the makefile. On Solaris the shell in /bin/sh is not standards
> compliant according to
> http://docs.sun.com/app/docs/doc/816-5165/sh-1?a=view so the patch
> fixes the configure script so a proper sh in located in /usr/xpg4/bin
> when building on OpenSolaris. Other platforms defaults to whatever is
> in the path when configure is running.
>
> Please consider this patch so qemu builds out-of-the-box for
> OpenSolaris...
>
> Best regards
> Palle
>
> ------ start of patch
>
> Index: configure
> ===================================================================
> --- configure   (revision 6657)
> +++ configure   (working copy)
> @@ -34,6 +34,7 @@
>  make="make"
>  install="install"
>  strip="strip"
> +shell="`which sh`"
>
>  # parse CC options first
>  for opt do
> @@ -263,6 +264,7 @@
>  SunOS)
>      solaris="yes"
>      make="gmake"
> +    shell="/usr/xpg4/bin/sh"

This shell is part of package SUNWxcu4. Is this a mandatory or optional
package?
If it is optional, many installations won't provide /usr/xpg4/bin/sh.

Regards

Stefan Weil