From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LezGz-0000b7-Qo
	for qemu-devel@nongnu.org; Wed, 04 Mar 2009 17:09:05 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LezGx-0000aX-P9
	for qemu-devel@nongnu.org; Wed, 04 Mar 2009 17:09:04 -0500
Received: from [199.232.76.173] (port=59568 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LezGx-0000aU-Kg
	for qemu-devel@nongnu.org; Wed, 04 Mar 2009 17:09:03 -0500
Received: from mail-ew0-f173.google.com ([209.85.219.173]:48192)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1LezGw-0005Hi-QP
	for qemu-devel@nongnu.org; Wed, 04 Mar 2009 17:09:03 -0500
Received: by ewy21 with SMTP id 21so2454393ewy.34
	for <qemu-devel@nongnu.org>; Wed, 04 Mar 2009 14:08:56 -0800 (PST)
Message-ID: <49AEFBF3.2020509@codemonkey.ws>
Date: Wed, 04 Mar 2009 16:08:51 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] Get sh right on OpenSolaris/SPARC
References: <Pine.NEB.4.64.0903022047120.15645@otaku.freeshell.org>
In-Reply-To: <Pine.NEB.4.64.0903022047120.15645@otaku.freeshell.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Palle Lyckegaard wrote:
>
> The patch below solves a problem when building qemu on OpenSolaris/SPARC.
>
> "feature_to_c.sh: test: argument expected"
>
> There seemes to be a problem with how "features_to_c.sh" is started 
> from the makefile. On Solaris the shell in /bin/sh is not standards 
> compliant according to 
> http://docs.sun.com/app/docs/doc/816-5165/sh-1?a=view so the patch 
> fixes the configure script so a proper sh in located in /usr/xpg4/bin 
> when building on OpenSolaris. Other platforms defaults to whatever is 
> in the path when configure is running.
>
> Please consider this patch so qemu builds out-of-the-box for 
> OpenSolaris...

Why not change:

test -z "$output"

to

test "x$output" = "x"

Which I believe is a pretty common way to work around this problem.

Regards,

Anthony Liguori

> Best regards
> Palle
>
> ------ start of patch
>
> Index: configure
> ===================================================================
> --- configure   (revision 6657)
> +++ configure   (working copy)
> @@ -34,6 +34,7 @@
>  make="make"
>  install="install"
>  strip="strip"
> +shell="`which sh`"
>
>  # parse CC options first
>  for opt do
> @@ -263,6 +264,7 @@
>  SunOS)
>      solaris="yes"
>      make="gmake"
> +    shell="/usr/xpg4/bin/sh"
>      install="ginstall"
>      needs_libsunmath="no"
>      solarisrev=`uname -r | cut -f2 -d.`
> @@ -1178,6 +1180,7 @@
>  echo "INSTALL=$install" >> $config_mak
>  echo "CC=$cc" >> $config_mak
>  echo "HOST_CC=$host_cc" >> $config_mak
> +echo "SHELL=$shell" >> $config_mak
>  echo "AR=$ar" >> $config_mak
>  echo "STRIP=$strip -s -R .comment -R .note" >> $config_mak
>  # XXX: only use CFLAGS and LDFLAGS ?
>
>
> ------ end of patch
>
>
>