All of lore.kernel.org
 help / color / mirror / Atom feed
From: Philip Craig <philipc@snapgear.com>
To: Nir Tzachar <nir.tzachar@gmail.com>
Cc: netfilter-devel@vger.kernel.org, jengelh@medozas.de
Subject: Re: [PATCH]: Fix ipt_REJECT problem with nf_bridge
Date: Tue, 10 Mar 2009 15:43:34 +1000	[thread overview]
Message-ID: <49B5FE06.1010204@snapgear.com> (raw)
In-Reply-To: <9b2db90b0903092229l1a02e8abtaf3e94a3a5ed641e@mail.gmail.com>

Nir Tzachar wrote:
>> The problem arises from the following code
>> (net/ipv4/netfilter/ipt_REJECT.c line 221:)
>>
>>        if (hook != NF_INET_FORWARD
>> #ifdef CONFIG_BRIDGE_NETFILTER
>>            || (nskb->nf_bridge && nskb->nf_bridge->mask & BRNF_BRIDGED)
>> #endif
>>           )
>>                addr_type = RTN_LOCAL;
>>
>> but, as nskb was newly allocated just a few line back, the
>> oldskb->nf_bridge was never copied, so nskb->nf_bridge is always NULL.

Is there a reason you need to copy it into nskb, rather
than just changing the test to check oldskb?

I don't think ipv4 netfilter should be setting this field
for new packets.  The bridging code will do that if needed
when it receives the packet.


  reply	other threads:[~2009-03-10  5:42 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-26  8:48 [PATCH]: Fix ipt_REJECT problem with nf_bridge Nir Tzachar
2009-03-10  5:29 ` Nir Tzachar
2009-03-10  5:43   ` Philip Craig [this message]
2009-03-11  9:29     ` Nir Tzachar
2009-03-11 11:44       ` Nir Tzachar
2009-03-12  1:04         ` Philip Craig
2009-03-12  3:25           ` Jan Engelhardt
2009-03-12  6:04             ` Philip Craig
2009-03-12 10:35               ` Jan Engelhardt
     [not found]                 ` <9b2db90b0903120516n1f9e67ck8994c9b92bb6aa0a@mail.gmail.com>
2009-03-12 12:17                   ` Nir Tzachar
2009-03-13  0:50                 ` Philip Craig
2009-03-16 15:11             ` Patrick McHardy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49B5FE06.1010204@snapgear.com \
    --to=philipc@snapgear.com \
    --cc=jengelh@medozas.de \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=nir.tzachar@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.