[U-Boot] [PATCH] 83xx: correctly set encryption and I2C bus 0 clock

From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] 83xx: correctly set encryption and I2C bus 0 clock
Date: Wed, 11 Mar 2009 09:33:04 +0100	[thread overview]
Message-ID: <49B77740.7010400@denx.de> (raw)
In-Reply-To: <49B767DC.7020205@aimvalley.nl>

Hello Norbert,

added Kim Phillips to cc as he is the 83xx maintainer

Norbert van Bolhuis wrote:
> This patch makes sure the correct mask is applied when setting
> the encryption and I2C bus 0 clock in SCCR.
> Failing to do so may lead to ENCCM being 0 in which case I2C bus 0
> won't function.
>
>
> --- cpu/mpc83xx/cpu_init.c.org  2009-03-11 07:56:57.000000000 +0100
> +++ cpu/mpc83xx/cpu_init.c      2009-03-11 07:57:37.000000000 +0100
> @@ -106,7 +106,7 @@ void cpu_init_f (volatile immap_t * im)
>   #ifdef CONFIG_SYS_SCCR_ENCCM
>          /* Encryption clock mode */
>          im->clk.sccr = (im->clk.sccr & ~SCCR_ENCCM) |
> -                      (CONFIG_SYS_SCCR_ENCCM << SCCR_PCICM_SHIFT);
> +                      (CONFIG_SYS_SCCR_ENCCM << SCCR_ENCCM_SHIFT);
>   #endif
>
>   #ifdef CONFIG_SYS_SCCR_PCICM
>
>
> Signed-off-by: Norbert van Bolhuis <nvbolhuis@aimvalley.nl>
>   

Can you please use git-format-patch for making a patch?
Otherwise your patch seems okay to me,

thanks
Heiko

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany 