From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] kvm: external module: support building against Windriver 2.0 (kernel 2.6.21) Date: Sun, 15 Mar 2009 12:24:17 +0200 Message-ID: <49BCD751.6010106@redhat.com> References: <49B94F09.90302@siemens.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Bernhard Kohl , kvm@vger.kernel.org To: Jan Kiszka Return-path: Received: from mx2.redhat.com ([66.187.237.31]:44384 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752974AbZCOKY0 (ORCPT ); Sun, 15 Mar 2009 06:24:26 -0400 In-Reply-To: <49B94F09.90302@siemens.com> Sender: kvm-owner@vger.kernel.org List-ID: Jan Kiszka wrote: > Bernhard Kohl wrote: > >> This is needed to compile kvm in a Windriver 2.0 distribution >> (kernel 2.6.21). This kernel has an include file marker.h, but >> trace_mark is not defined there. So the compat code in >> kernel/include-compat/linux/marker.h is not included. >> > > I bet this is because Wind River patched some variant of LTTng into > their kernel. > > However, I'm unsure if supporting significantly modified distribution > kernels is in the scope of this compat layer. Yes, for example we support the RHEL 5 series, which significantly deviates from plain 2.6.18. > If it is ok for the > maintainers, you should try to make the test more Wind River specific > (did you check that there is no side-effect for normal <= 2.6.21 > kernels?) and maybe add a comment. > Best would be to check for a Wind River kernel as this is likely to break on mainline Linux. -- error compiling committee.c: too many arguments to function