From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kazuaki Ichinohe Date: Mon, 30 Mar 2009 17:27:39 +0900 Subject: [U-Boot] [PATCH] Canyonlands SATA harddisk driver In-Reply-To: <20090327163144.E7D06832E406@gemini.denx.de> References: <49BFA0BE.7060103@fsi.co.jp> <200903241722.55723.sr@denx.de> <49CA164C.4080906@fsi.co.jp> <200903251704.22803.sr@denx.de> <49CB5F77.1060304@fsi.co.jp> <20090327163144.E7D06832E406@gemini.denx.de> Message-ID: <49D0827B.7010000@fsi.co.jp> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hello Denk, After confirming operation, I'll send sata_dwc.c with cmd_sata.c again. Regards, Kazuaki Ichinohe Wolfgang Denk wrote: > Dear Kazuaki Ichinohe, > > In message <49CB5F77.1060304@fsi.co.jp> you wrote: > ... >> >Why do you add this 460EX SATA support to cmd_scsi.c? Wouldn't cmd_sata.c be a >> >better place? Or did I miss something here? >> >> The cmd_scsi.c which define CONFIG_CMD_SCSI are modified >> because I want to use scsiboot command of U-BOOT. > > This makes no sense. It is a S-ATA driver, not a SCSI driver, and as > such it has to be supported in the context of the S-ATA support. > > I explicitly NAK the changes to the SCSI related files. > > Best regards, > > Wolfgang Denk >