All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tom <Tom.Rix@windriver.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] ZOOM2 Add initial support for Zoom2
Date: Wed, 01 Apr 2009 15:46:48 -0500	[thread overview]
Message-ID: <49D3D2B8.4050104@windriver.com> (raw)
In-Reply-To: <20090401195126.GB28740@ld0162-tx32.am.freescale.net>

Scott Wood wrote:
> On Wed, Apr 01, 2009 at 11:11:09AM -0500, Tom Rix wrote:
>   
>> +#define WRITE_NAND_COMMAND(d, adr)\
>> +			writel(d, &nand_cs_base->nand_cmd)
>> +#define WRITE_NAND_ADDRESS(d, adr)\
>> +			writel(d, &nand_cs_base->nand_adr)
>> +#define WRITE_NAND(d, adr) writew(d, &nand_cs_base->nand_dat)
>> +#define READ_NAND(adr) readl(&nand_cs_base->nand_dat)
>> +
>> +/* Other NAND Access APIs */
>> +#define NAND_WP_OFF() do {readl(&gpmc_cfg_base->config) |= GPMC_CONFIG_WP; } \
>> +			while (0)
>> +#define NAND_WP_ON() do {readl(&gpmc_cfg_base->config) &= ~GPMC_CONFIG_WP; } \
>> +			while (0)
>> +#define NAND_DISABLE_CE(nand)
>> +#define NAND_ENABLE_CE(nand)
>> +#define NAND_WAIT_READY(nand)	udelay(10)
>>     
>
> This is the legacy NAND interface which is deprecated and will be removed
> very soon.  You don't seem to be selecting legacy NAND support, so these
> defines (and some others earlier in the file) are just dead code.  Please
> remove them.
>
>   
OK
Since this was a copy from Zoom1, I will also change Zoom1.

> -Scott
>   

  reply	other threads:[~2009-04-01 20:46 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-01 16:11 [U-Boot] [PATCH] ZOOM2 Add initial support for Zoom2 Tom Rix
2009-04-01 16:11 ` [U-Boot] [PATCH] ZOOM2 Mux changes to support zoom2 configuration Tom Rix
2009-04-01 16:11   ` [U-Boot] [PATCH] ZOOM2 Add support for debug board detection Tom Rix
2009-04-01 16:11     ` [U-Boot] [PATCH] ZOOM2 Add serial support Tom Rix
2009-04-01 16:11       ` [U-Boot] [PATCH] ZOOM2 Add led support Tom Rix
2009-04-01 20:25       ` [U-Boot] [PATCH] ZOOM2 Add serial support Wolfgang Denk
2009-04-01 20:45         ` Tom
2009-04-01 21:36           ` Wolfgang Denk
2009-04-01 20:21     ` [U-Boot] [PATCH] ZOOM2 Add support for debug board detection Wolfgang Denk
2009-04-01 19:51 ` [U-Boot] [PATCH] ZOOM2 Add initial support for Zoom2 Scott Wood
2009-04-01 20:46   ` Tom [this message]
2009-04-01 20:19 ` Wolfgang Denk
2009-04-02  0:53   ` Tom
2009-04-01 19:07 Tom Rix

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49D3D2B8.4050104@windriver.com \
    --to=tom.rix@windriver.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.