From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1763202AbZDCKyq (ORCPT ); Fri, 3 Apr 2009 06:54:46 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1761598AbZDCKyP (ORCPT ); Fri, 3 Apr 2009 06:54:15 -0400 Received: from mx2.redhat.com ([66.187.237.31]:58050 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1761302AbZDCKyN (ORCPT ); Fri, 3 Apr 2009 06:54:13 -0400 Message-ID: <49D5E9B5.1020101@redhat.com> Date: Fri, 03 Apr 2009 13:49:25 +0300 From: Izik Eidus User-Agent: Thunderbird 2.0.0.21 (Windows/20090302) MIME-Version: 1.0 To: Gerd Hoffmann CC: Chris Wright , Anthony Liguori , Andrea Arcangeli , linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org, avi@redhat.com, riel@redhat.com, jeremy@goop.org, mtosatti@redhat.com, hugh@veritas.com, corbet@lwn.net, yaniv@redhat.com, dmonakhov@openvz.org Subject: Re: [PATCH 5/4] update ksm userspace interfaces References: <20090331142533.GR9137@random.random> <49D22A9D.4050403@codemonkey.ws> <20090331150218.GS9137@random.random> <49D23224.9000903@codemonkey.ws> <20090331151845.GT9137@random.random> <49D23CD1.9090208@codemonkey.ws> <20090331162525.GU9137@random.random> <49D24A02.6070000@codemonkey.ws> <20090402012215.GE1117@x200.localdomain> <49D424AF.3090806@codemonkey.ws> <20090402053114.GF1117@x200.localdomain> <49D4BE64.8020508@redhat.com> <49D5E1EE.6030707@redhat.com> In-Reply-To: <49D5E1EE.6030707@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Gerd Hoffmann wrote: > Izik Eidus wrote: > >> The main problem that ksm will face when removing the fd interface is: >> right now when you register memory into ksm, you open fd, and then ksm >> do get_task_mm(), we will do mmput when the file will be closed >> > > Did you test whenever it really cleans up in case you "kill -9 qemu"? > > I recently did something simliar with the result that the extra > reference hold on mm_struct prevented the process memory from being > zapped ... > > cheers, > Gerd > Did you use mmput() after you called get_task_mm() ??? get_task_mm() do nothing beside atomic_inc(&mm->mm_users); and mmput() do nothing beside dec this counter and check if no reference are available to this.... Am i missing anything? From mboxrd@z Thu Jan 1 00:00:00 1970 From: Izik Eidus Subject: Re: [PATCH 5/4] update ksm userspace interfaces Date: Fri, 03 Apr 2009 13:49:25 +0300 Message-ID: <49D5E9B5.1020101@redhat.com> References: <20090331142533.GR9137@random.random> <49D22A9D.4050403@codemonkey.ws> <20090331150218.GS9137@random.random> <49D23224.9000903@codemonkey.ws> <20090331151845.GT9137@random.random> <49D23CD1.9090208@codemonkey.ws> <20090331162525.GU9137@random.random> <49D24A02.6070000@codemonkey.ws> <20090402012215.GE1117@x200.localdomain> <49D424AF.3090806@codemonkey.ws> <20090402053114.GF1117@x200.localdomain> <49D4BE64.8020508@redhat.com> <49D5E1EE.6030707@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Chris Wright , Anthony Liguori , Andrea Arcangeli , linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org, avi@redhat.com, riel@redhat.com, jeremy@goop.org, mtosatti@redhat.com, hugh@veritas.com, corbet@lwn.net, yaniv@redhat.com, dmonakhov@openvz.org To: Gerd Hoffmann Return-path: In-Reply-To: <49D5E1EE.6030707@redhat.com> Sender: owner-linux-mm@kvack.org List-Id: kvm.vger.kernel.org Gerd Hoffmann wrote: > Izik Eidus wrote: > >> The main problem that ksm will face when removing the fd interface is: >> right now when you register memory into ksm, you open fd, and then ksm >> do get_task_mm(), we will do mmput when the file will be closed >> > > Did you test whenever it really cleans up in case you "kill -9 qemu"? > > I recently did something simliar with the result that the extra > reference hold on mm_struct prevented the process memory from being > zapped ... > > cheers, > Gerd > Did you use mmput() after you called get_task_mm() ??? get_task_mm() do nothing beside atomic_inc(&mm->mm_users); and mmput() do nothing beside dec this counter and check if no reference are available to this.... Am i missing anything? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org