From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LppYW-0005rH-C2
	for qemu-devel@nongnu.org; Fri, 03 Apr 2009 16:00:00 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LppYR-0005qa-6T
	for qemu-devel@nongnu.org; Fri, 03 Apr 2009 15:59:59 -0400
Received: from [199.232.76.173] (port=39435 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LppYQ-0005qV-Vv
	for qemu-devel@nongnu.org; Fri, 03 Apr 2009 15:59:55 -0400
Received: from mx2.redhat.com ([66.187.237.31]:59073)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kraxel@redhat.com>) id 1LppYQ-0007jQ-9T
	for qemu-devel@nongnu.org; Fri, 03 Apr 2009 15:59:54 -0400
Message-ID: <49D66AB4.5030105@redhat.com>
Date: Fri, 03 Apr 2009 21:59:48 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 02/10] xen: backend driver core
References: <1238621982-18333-1-git-send-email-kraxel@redhat.com>	
	<1238621982-18333-3-git-send-email-kraxel@redhat.com>
	<f43fc5580904020949m15a70403rcb44c50937ae647a@mail.gmail.com>
In-Reply-To: <f43fc5580904020949m15a70403rcb44c50937ae647a@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: xen-devel@lists.xensource.com, qemu-devel@nongnu.org

Blue Swirl wrote:
> On 4/2/09, Gerd Hoffmann <kraxel@redhat.com> wrote:
>> This patch adds infrastructure for xen backend drivers living in qemu,
>>  so drivers don't need to implement common stuff on their own.  It's
>>  mostly xenbus management stuff: some functions to access xentore,
>>  setting up xenstore watches, callbacks on device discovery and state
>>  changes, handle event channel, ...
>>
>>  Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> 
>>  + *  You should have received a copy of the GNU General Public License
>>  + *  along with this program; if not, write to the Free Software
>>  + *  Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
> 
> The address is now 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.

Will fix.

>>  +    if (NULL == node  ||  0 == strcmp(node, "online")) {
>>  +       if (-1 == xenstore_read_be_int(xendev, "online", &xendev->online))
> 
> This style is alien.

Oops.  Still one of them.  I though I've killed them all, will check again.

cheers,
  Gerd